Php Update mysql

Question

Hello i've actually a table to update throught php/html and have no clue why I got the error "Error" (which is my mysql_query die) I've tried if every variable in my code were send in my update.php and everything was here. So the problem come from my update.php code.

Here is my updating code:

<?php 
   include('config.inc.php');
   $idn = $_POST["idn"];
   $nom = $_POST['nom'];
   $prenom = $_POST["prenom"];
   $payss = $_POST["pays"];

   $req = "UPDATE membres SET prenom = '$prenom' , "
                             ." pays = '$payss' "
                             ." nom = '$nom' , "
                             ." where id = $idn ";
   $res = mysql_query( $req ) or die ("error updating!");
?>

Thanks for your answers !

remove the custom error and put mysql_error. Basically it should be because SET col = a, col2 = b, WHERE is invalid syntax, WHERE is not a column, it doesn't need a comma, also before the second column the one is needed — Ivan Yonkov
– Ivan Yonkov, Commented Aug 27, 2013 at 5:30
You're missing a comma in this line ." pays = '$payss' ", and have extra comma in this line ." nom = '$nom' , " — vee
– vee, Commented Aug 27, 2013 at 5:30
You should echo out the error like they do in the manual, and take note of the warning on top of the page, mysql_* functions are deprecated and should not be used. — JimL
– JimL, Commented Aug 27, 2013 at 5:31
consider to use mysql_real_escape_string($input) before converting to mysqli and PDO (prepared statement) because your code is vulnerable to SQL injection attack! — user1646111
– user1646111, Commented Aug 27, 2013 at 5:33

Prasannjit · Accepted Answer · 2013-08-27 05:32:07Z

2

<?php 
include('config.inc.php');
$idn=$_POST["idn"];
$nom=$_POST['nom'];
$prenom=$_POST["prenom"];
$payss=$_POST["pays"];

$req="UPDATE membres SET prenom = '".addslashes($prenom)."' ,pays = '".addslashes($payss)."',nom = '".addslashes($nom)."' where id = '".$idn."'";
$res=mysql_query($req) or die ("error updating!");
?>

answered Aug 27, 2013 at 5:32

Prasannjit

7954 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jay · Accepted Answer · 2013-08-27 05:32:30Z

0

try this one

$req="UPDATE membres SET prenom = '".$prenom."' , pays = '".$payss."'  nom = '".$nom."',  where id = ".$idn;

answered Aug 27, 2013 at 5:32

Jay

8613 gold badges20 silver badges52 bronze badges

Comments

Girish Thimmegowda · Accepted Answer · 2013-08-27 05:33:47Z

0

$req="UPDATE membres SET prenom = '$prenom' , pays = '$payss',  nom = '$nom'  where id = $idn ";

answered Aug 27, 2013 at 5:33

Girish Thimmegowda

2,1792 gold badges14 silver badges15 bronze badges

Comments

Alexander Maximiuk · Accepted Answer · 2013-08-27 05:34:02Z

0

Maybe?

$req = "UPDATE `membres` SET `prenom` = '".$prenom."', 
        `pays` = '".$payss."'
        `nom` = '".$nom."'
        where `id` = ".$idn;
$res = mysql_query($req) or die ("error updating!");

answered Aug 27, 2013 at 5:34

Alexander Maximiuk

741 silver badge7 bronze badges

Comments

Devang Rathod · Accepted Answer · 2013-08-27 05:36:23Z

0

Try this

$req="UPDATE membres SET prenom = $prenom, pays = $payss, nom = $nom where id = $idn ";

answered Aug 27, 2013 at 5:36

Devang Rathod

6,7342 gold badges25 silver badges32 bronze badges

Comments

RenkyaZ · Accepted Answer · 2013-08-27 05:56:09Z

0

I strongly recommend to use MySQLi with a prepared statement in order to avoid the risk of SQL injection.

$req = "UPDATE membres
           SET prenom = ?,
               pays = ?,
               nom = ?
         WHERE id = ?";

$mysqli = new mysqli("localhost", "my_user", "my_password", "world");
$stmt = $mysqli->prepare($req);
$stmt->bind_param("sssi", $prenom, $payss, $nom, $idn);
$stmt->execute();
$stmt->close();
$mysqli->close();

edited Aug 27, 2013 at 5:56

answered Aug 27, 2013 at 5:39

RenkyaZ

1085 bronze badges

Comments

Ramesh · Accepted Answer · 2013-08-27 07:17:52Z

0

There is syntax error in you query . Add coma(",") after second param (after '$payss' ) and remove coma before where condition. here is updated query

$req = "UPDATE membres SET prenom = '$prenom' , "
                             ." pays = '$payss', "
                             ." nom = '$nom'  "
                             ." where id = $idn ";

answered Aug 27, 2013 at 7:17

Ramesh

11 silver badge3 bronze badges

Collectives™ on Stack Overflow

Php Update mysql

7 Answers 7

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related