Using For loop in mysql statement getting slow in vb.net

Question

This is my code for insert and update statement:

For i = 0 To lvFabric1.Items.Count - 1

            strQ4 = ""
            strQ4 = strQ4 & "INSERT into js_det(LINE_NO, FABRIC1, FABRIC2, `DESC`) SELECT LPAD('" & i + 1 & "',2, '0'), '" & lvFabric1.Items(i).Text & "','sdf', `DESC` from rm_inv where ITEM_CODE = '" & lvFabric1.Items(i).Text & "'"

            strQ5 = ""
            strQ5 = strQ5 & "UPDATE js_det set TRAN_NO = (SELECT JS_TRAN FROM counter) where Fabric1 = '" & lvFabric1.Items(i).Text & "'"

            cmd.CommandText = strQ4
            cmd.ExecuteNonQuery()

            cmd.CommandText = strQ5
            cmd.ExecuteNonQuery()

        Next

What the problem here is that its getting slower if it is looping 5 times and above, it take above 3 second. How can I speed up this code? or is there another way?

Thanks for the help.

Rex · Accepted Answer · 2013-08-28 08:42:10Z

3

To speed it up, commit the whole thing in one go, somthing like:

Dim sqls As New List(Of String)
For i = 0 To lvFabric1.Items.Count - 1
    sqls.Add("INSERT into js_det(LINE_NO, FABRIC1, FABRIC2, `DESC`) SELECT LPAD('" & i + 1 & "',2, '0'), '" & lvFabric1.Items(i).Text & "','sdf', `DESC` from rm_inv where ITEM_CODE = '" & lvFabric1.Items(i).Text & "'")

    sqls.Add("UPDATE js_det set TRAN_NO = (SELECT JS_TRAN FROM counter) where Fabric1 = '" & lvFabric1.Items(i).Text & "'")
Next
If sqls.Any() Then
    cmd.CommandText = sqls.Aggregate(Function(m, n) m & ";" & n)
    cmd.ExecuteNonQuery()
End If

However, it's not a recommended way to do sql query in .net.

SQL parameter should be used to avoid any sql injection or sql syntax error.

EDIT: using sql parameter -

    Using con As New SqlConnection("My connection string..."),
        cmd As New SqlCommand(sql, con)
        cmd.CommandText = "UPDATE js_det set TRAN_NO = (SELECT JS_TRAN FROM counter) where Fabric1 = @fabric"
        Dim fabricParam = cmd.Parameters.Add("@fabric", SqlDbType.VarChar)

        con.Open()
        For i = 0 To lvFabric1.Items.Count - 1
            fabricParam.Value = lvFabric1.Items(i).Text
            cmd.ExecuteNonQuery()
        Next
        con.Close()

    End Using

edited Aug 28, 2013 at 8:42

answered Aug 28, 2013 at 8:36

Rex

2,13011 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Matthew Over a year ago

ahh ok sir, I will try this one, tnx

Collectives™ on Stack Overflow

Using For loop in mysql statement getting slow in vb.net

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related