Uploading file via PHP in form

Question

(beginner)

I'm having trouble uploading my file. I see the filename being posted to the database, but the file is not being posted to the images folder. It seems as though nothing is happening. Here is my following code, please advise me what I need to change:

<?php
//the $art variable gets posted to a database eventually
    $art = mysql_real_escape_string(stripslashes($_FILES["art"]["name"]));
$art_ext = pathinfo($art, PATHINFO_EXTENSION);
$art = md5($art).".".$art_ext;
if($art!=""){
    move_uploaded_file($art, "images/".$art );
}
?>
<script type="text/javascript">
$(function(){
    image_upload = {
        UpdatePreview: function(obj){
          // if IE < 10 doesn't support FileReader
          if(!window.FileReader){
             // don't know how to proceed to assign src to image tag
          } else {
             var reader = new FileReader();
             var target = null;

             reader.onload = function(e) {
              target =  e.target || e.srcElement;
               $("#imageupload").attr("src", target.result);
             };
              reader.readAsDataURL(obj.files[0]);
          }
        }
    };
});
    </script>
    <form action="new.php" method="post" enctype="multipart/form-data">
<input type='file' name='art' id="file" onchange='image_upload.UpdatePreview(this)' value="Upload"  accept="image/gif,image/jpeg,image/png"/>
        </p>
        <p>upload a image! (.gif, .jpg, .png formats allowed. 5MB max)</p>
        <img id="imageupload" src="1x1.png" alt="test" />
<input type="submit" class="smallbtn4" style="cursor:pointer;" value="post"/>
</form>

It looks to me to be a problem with the filename. The 1st var for the move_uploaded_file function is the actual name of the uploaded file - you can't md5 that first. What you probably intended to do was save it with an md5 hashed name. Reviewing the function's definition, we see the following: bool move_uploaded_file ( string $filename , string $destination ) - I suggest you find and download 'php_enhanced_en.chm' if you're an english speaker. It's the php help-file, with the enhancement of user-comments from the PHP site. It's about 29MB (it contains 1000's of code snippets) — enhzflep
– enhzflep, Commented Aug 28, 2013 at 22:55

StackSlave · Accepted Answer · 2013-08-28 23:11:16Z

1

Here's the format for move_uploaded_file():

$path = 'images/';
move_uploaded_file($_FILES['art']['tmp_name'], $path.basename($_FILES['art']['name']));

answered Aug 28, 2013 at 23:11

StackSlave

10.6k2 gold badges20 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

pedrum golriz Over a year ago

AWESOME! I did the following move_uploaded_file($_FILES['art']['tmp_name'], "images/".$art );

StackSlave Over a year ago

If you use my library at PHPglue.com it could make your life a lot easier.

A.O. · Accepted Answer · 2013-08-28 22:58:32Z

1

when using move_uploaded_files() your destination path should also include the name of the file....right now your destination path is:

images/

it should be:

images/nameOfImg.ext

Hope this helps!

EDIT:

After seeing the comment by @enhzflep, you should also hash the name of the file and create your filename string before using it in move_uploaded_file();

edited Aug 28, 2013 at 22:58

answered Aug 28, 2013 at 22:52

A.O.

3,7636 gold badges32 silver badges49 bronze badges

1 Comment

pedrum golriz Over a year ago

Okay so I changed a couple things around, I actually see the file uploading but I still don't see it in the file path.

$art = mysql_real_escape_string(stripslashes($_FILES["art"]["name"]));  	$art_ext = pathinfo($art, PATHINFO_EXTENSION); 	$art = md5($art).".".$art_ext; 	if($art!=""){ 		move_uploaded_file($art, "images/".$art ); 	}

Collectives™ on Stack Overflow

Uploading file via PHP in form

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related