Function failure - shell script converted from Bash to Korn

Question

I wrote a shell script that does data manipulation on a server running bash shell.

My script has a function which retrieves data inside ZIP files

function getCTLfile() {
  for i in ${Array[@]}; do 
    if [[ `echo ${i}|awk -F . '{print $NF}'` == "ctl" ]]; then 
      echo "${i}" 
    fi
  done
}

It works great but this machine hardware is faulty so our sysadmin requested that I port my code to another server running Korn shell.

When I run my script, it fails on my function!! Even if I type it from the command line.

$ function getCTLfile() {
-ksh: syntax error: `(' unexpected

Do I need to change my syntax anywhere? I did some research and it seems that everything should work.

code review: if [[ "$i" == *.ctl ]] is much clearer. You almost certainly want to quote "${Array[@]}" — glenn jackman
– glenn jackman, Commented Aug 29, 2013 at 19:45
case $i in *.ctl) echo "$i";; esac is a lot simpler, portable, and idiomatic. — tripleee
– tripleee, Commented Aug 29, 2013 at 19:59

Emmet · Accepted Answer · 2013-08-29 19:40:32Z

6

The function declaration syntax in ksh either uses the function keyword or the parentheses, but not both. Leave out either the parentheses or the function keyword and it should work.

answered Aug 29, 2013 at 19:40

Emmet

6,45128 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Chris Over a year ago

Damn. I did not pay attention to that little detail. Bingo. Accepted and voted up. I was going nuts! Thank you!!!

cdarke Over a year ago

@Chris: By the way, please note there are differences in functionality between the two syntaxes in ksh93, specifically with the scope of declared (typeset) variables.

Collectives™ on Stack Overflow

Function failure - shell script converted from Bash to Korn

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related