Cannot set a variable in a batch file

Question

I have the following...

@ECHO OFF
setlocal EnableDelayedExpansion

for /f "skip=1" %%p in ('wmic cpu get loadpercentage') do @echo %%p
ECHO ...this worked
ECHO. 
PAUSE

for /f "skip=1" %%p in ('wmic cpu get loadpercentage') do set cpu=%%p
ECHO cpu is %cpu%
ECHO ...this did not work
ECHO. 
PAUSE

How come I can't set the number in the variable %cpu% it's always blank!

Thanks a_horse_with_no_name for the re-formatting :)

TheThankfulOne
– TheThankfulOne

2013-09-03 17:33:14 +00:00
Commented Sep 3, 2013 at 17:33 — TheThankfulOne
– TheThankfulOne, Commented Sep 3, 2013 at 17:33

npocmaka · Accepted Answer · 2013-09-03 18:03:14Z

3

for /f "skip=1" %%p in ('wmic cpu get loadpercentage') do set cpu=%%p & goto :end_for
:end_for

WMIC produces an empty line at the end.You can try also with /format:csv at the end of wmic call which will prevent that.

Check also this: http://www.dostips.com/forum/viewtopic.php?f=3&t=4266

edited Sep 3, 2013 at 18:03

answered Sep 3, 2013 at 17:41

npocmaka

57.8k19 gold badges162 silver badges199 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

TheThankfulOne Over a year ago

This worked, thank you very much! Appreciate the explanation too!

eiselems · Accepted Answer · 2013-09-03 17:44:56Z

0

Have not found a solution quite yet but the problem seems to be that

wmic cpu get loadpercentage

has more than your two lines in the output, the for loop iterates over all lines

if i actually echo all sets in the for loop it looks like this

set cpu=1
set cpu=
cpu is

answered Sep 3, 2013 at 17:44

eiselems

1802 silver badges12 bronze badges

Collectives™ on Stack Overflow

Cannot set a variable in a batch file

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related