Asp.Net Class - problem returning html string value

Question

I'm trying to get my class to return a html string which I then assign to a control on a aspx page as: this.div1.InnerHtml = class.News();

However, my catch code is always firing, returning my 'NoValue' message.

The code works fine outside of the class.

When I comment out the reader lines htmlStr.Append(reader["Title"].ToString()); I can get the string back to my calling code, is there something else I need to do, to use readers in classes?

namespace confonline {

public class conf
{
    private string connectionStringBMP = WebConfigurationManager.ConnectionStrings["ConfBMP"].ConnectionString;

    public string News()
    {

        SqlConnection conn = new SqlConnection(connectionStringBMP);
        SqlCommand cmd = new SqlCommand("spNews ", conn);
        cmd.CommandType = CommandType.StoredProcedure;
        cmd.Parameters.AddWithValue("@number",2);

        SqlDataReader reader;

        try
        {
            conn.Open();

            reader = cmd.ExecuteReader();
            StringBuilder htmlStr = new StringBuilder("");

            while (reader.Read())
            {
               htmlStr.Append("<div class='news'>");
                htmlStr.Append("<img align='left' title='" + reader["ThumbnailText"].ToString() + "' alt='" + reader["ThumbnailText"].ToString() + "' src='images/news/thumbnails/" + reader["PublishYear"].ToString() + "/" + reader["Photo"].ToString() + "'>");
                htmlStr.Append("<a href=news.aspx?p=" + reader["ID"] + ">");
                htmlStr.Append(reader["Title"].ToString());
                htmlStr.Append("</a>");
                htmlStr.Append("</div>");
            }

             string htmlString = htmlStr.ToString();

             reader.Close();

             return htmlString;

        }
        catch (Exception err)
        {
            HttpContext.Current.Response.Write(err.Message);
            string noVal = "No Value";
            return noVal;

        }
        finally
        {
            conn.Close();
        }

    }
}

}

You will need to capture the exact exception thrown. If it works outside the class, maybe you need to check how did you call the method in the first place. — o.k.w
– o.k.w, Commented Dec 7, 2009 at 23:50

Li0liQ · Accepted Answer · 2009-12-07 23:48:56Z

3

Look closer at the Exception you get. reader["Title"] can be null.

answered Dec 7, 2009 at 23:48

Li0liQ

11.3k38 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Edgar Hernandez Over a year ago

In fact, all of your access to the reader could be null (unless your fields are declared not null in the database).

Li0liQ Over a year ago

Yep, but Melt is getting Exception at that exact line;). There can be a null in the DB or wrong column name or whatever.

µBio · Accepted Answer · 2009-12-07 23:50:17Z

1

if it works when you comment out

 htmlStr.Append(reader["Title"].ToString());

as you say, then there is an exception on that line. Maybe "Title" isn't a valid column? or is sometimes null?

answered Dec 7, 2009 at 23:50

µBio

10.8k6 gold badges41 silver badges56 bronze badges

Collectives™ on Stack Overflow

Asp.Net Class - problem returning html string value

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related