For Loop in C- implementation

Question

I am confused on how to complete this for loop. The mission is to read input in unix. For the input if the radius is >0 it should prompt the user each time and then if <=0 it should terminate. I am going from centimeters to square inches. My current configuration requires 2 inputs (1 prompted, 1 not) before giving output to the console. Cheers.

#include <stdio.h>
#define PI 3.14159

main()
{
float r, a;
  int y = 9999999;


  for(int i =0; i <y; i++){
     printf("Enter the circle's radius (in centimeters): ");
     scanf ("%f", &r);

        if(r>0){
           r=r;
       a = PI * r * r *2.54;

       printf("Its area is %3.2f square inches.\n", a);
   }  else {}
     }

  }

You should consider it a fatal mistake to ignore the result of scanf. — Kerrek SB
– Kerrek SB, Commented Sep 6, 2013 at 17:18
Actually you should divide by 2.54, not multiply, and you should do it twice, not once. And what's this r=r; business? — Mike Dunlavey
– Mike Dunlavey, Commented Sep 6, 2013 at 17:19
Note that else {} is just noise for the sake of adding noise. It does nothing useful. — Jonathan Leffler
– Jonathan Leffler, Commented Sep 6, 2013 at 17:33
Is there some significance to the use of "C-" in your title? There actually is a language called "C--", and I've heard of a joke language called "C-", named after the grade its author received in a language design course. Your title needn't say what language you're using (the tag does that), and it should describe the problem you're having. — Keith Thompson
– Keith Thompson, Commented Sep 6, 2013 at 17:38

Jack · Accepted Answer · 2013-09-06 17:18:07Z

2

Your code flow is the following:

for (infinite condition) {
  scan input
  if (input > 0) {
    do things
  }
  else {
    do nothing
  }
}

So there's no way to exit out of the loop, that's why the break statement exists, to force quitting an iterative block of code:

while (true) {
  scanf ("%f", &r);
  if (r > 0) {
    // do whatever;
  }
  else
    break;
}

The break will stop the cycle when executed, just going out of the loop.

answered Sep 6, 2013 at 17:18

Jack

134k33 gold badges252 silver badges349 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Jonathan Leffler Over a year ago

It's not infinite; it is just shy of 10 million iterations, which is a long way off infinite in any mathematical sense. In fact, only in the sense of 'humans won't type that many entries' is it infinite. If the data comes from a file, 10 million lines isn't a big problem (though the count still shouldn't be hard-coded; it should be conditioned on EOF).

Jack Over a year ago

@JonathanLeffler: It's an assumption I made to simplify the problem and focus on the question itself. Actually input is parsed from stdin so the only break condition should be EOF as you point out.

zoska Over a year ago

@Jack: Not a very good assumption, it really can confuse the inexperienced reader. Stating that this loop will never finish is just plainly wrong.

sheepez · Accepted Answer · 2013-09-06 18:13:41Z

1

You may want to try using a while loop instead so that the question is continually prompted until the user inputs a value =>0. see if below helps (also your conversion factor was not quite right);

#include <stdio.h>
#define PI 3.14159

void main()
{
    float r, a;
    printf("Enter the cirle's radius (in centimeters):");
    scanf("%f",&r); 

    while (r>0)
    {
        a=PI*r*r*0.155; // conversion from sqcm to sqin is ~0.155
        printf("Its area is %3.2f square inches \n", a);
        printf("Enter the cirle's radius (in centimeters):");
        scanf("%f",&r);
    }
}

edited Sep 6, 2013 at 18:13

sheepez

1,0221 gold badge11 silver badges28 bronze badges

answered Sep 6, 2013 at 17:44

user2755190

361 bronze badge

Comments

P0W · Accepted Answer · 2013-09-06 17:35:07Z

1

r=1.0f;

// break if no. of cases exhausted or r is negative or zero
for(int i =0; i < y && r > 0; i++) 
{
     printf("Enter the circle's radius (in centimeters): ");

     if( scanf ("%f", &r) == 1) // Always check for successful scanf
     {
          a = PI * r * r/2.54/2.54; //This is correct formula

          printf("Its area is %3.2f square inches.\n", a);
     } 

 }

edited Sep 6, 2013 at 17:35

answered Sep 6, 2013 at 17:28

P0W

48.1k9 gold badges78 silver badges124 bronze badges

Comments

But I'm Not A Wrapper Class · Accepted Answer · 2013-09-06 18:32:45Z

1

Consider a while loop instead:

#include <stdio.h>
#define PI 3.14159

main(){
    float r, a;

    int continueBool = 1;
    while(continueBool == 1){
         printf("Enter the circle's radius (in centimeters): ");
         scanf ("%f", &r);

         if(r>0){
              a = PI * r * r *2.54;
              //the above formula may be wrong, so consider trying:
              //a = PI * r * r/2.54/2.54;
              printf("Its area is %3.2f square inches.\n", a);
         }
         else{
             continueBool = 0;
         }
     }
}

The break statement can be dangerous if you are new to C programming, so I recommend not using it until you get a better understanding of C and break. If you do want to use break, then this could be your solution:

#include <stdio.h>
#define PI 3.14159

main(){
    float r, a;

    while(1){
         printf("Enter the circle's radius (in centimeters): ");
         scanf ("%f", &r);

         if(r<=0){
             break;
         }

         a = PI * r * r *2.54;
         //the above formula may be wrong, so consider trying:
         //a = PI * r * r/2.54/2.54;
         printf("Its area is %3.2f square inches.\n", a);
     }
}

edited Sep 6, 2013 at 18:32

answered Sep 6, 2013 at 17:21

But I'm Not A Wrapper Class

14.4k6 gold badges48 silver badges68 bronze badges

4 Comments

Jack Over a year ago

Please explain why break should be dangerous. It's perfectly fine to use it in this situation. It's readable and the duty of knowing which loop you are breaking in case of nested loops is of the programmer. Using a boolean variable when not needed is not just readable. Please take a look at: stackoverflow.com/questions/3922599/… and avoid personal opinions when not completed by explanations.

haccks Over a year ago

What is the problem with break statement?

But I'm Not A Wrapper Class Over a year ago

Break "can" be dangerous depending on programming skill level. It seems that the open poster is new to C programming. Getting him/her into the practice of using "break" statements over properly controlled loops is (in my opinion) a bad idea. However, learning break is still very important (I'm not saying it's not).

But I'm Not A Wrapper Class Over a year ago

Also, how can I avoid personal opinions if you are arguing readability and good/bad practices....?

haccks · Accepted Answer · 2013-09-06 17:24:15Z

0

Use this:

for(int i =0; i < y; i++)
{
     printf("Enter the circle's radius (in centimeters): ");
     scanf ("%f", &r);

     if(r > 0)
     {
          a = PI * r * r *2.54;

          printf("Its area is %3.2f square inches.\n", a);
     } 
     else
     {
          break;
     }
 }

edited Sep 6, 2013 at 17:24

answered Sep 6, 2013 at 17:18

haccks

107k28 gold badges181 silver badges274 bronze badges

1 Comment

haccks Over a year ago

@P0W; OK. Now it will terminate if r <= 0.

Collectives™ on Stack Overflow

For Loop in C- implementation

5 Answers 5

3 Comments

Comments

Comments

4 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

3 Comments

Comments

Comments

4 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related