Get SQL single value from query as String

Question

I have the following code in my code behind:

Dim name As String
name.text= Staff.LoadName(StaffID)

The following query in my Class:

Public Function LoadName(ByVal ID As String)
    Dim ds As New DataSet
    Dim SQL As String = ""
    SQL="select name from Staff where StaffID='" & ID & "' " 
    ds = Common.QueryDataByDataset(SQL)
    ds.Tostring()
    Return ds
End Function

But the name.Text doesn't show the value. How to I get the single value and convert it to string to display? Thanks

Beware the SQL injection vulnerability of this code - use parameters rather than string concatenation to create queries. — Richardissimo
– Richardissimo, Commented Mar 27, 2019 at 6:24

Doug Lamb · Accepted Answer · 2013-09-09 05:16:22Z

2

I am guessing the Common.QueryDataByDataset is from your library or some third party. Assuming it is executing the query and populating the dataset, you should be able to change the last two lines of the LoadName function to this:

String name = ds.Tables.Item("Staff").Rows(0)("name").ToString()
return name

You should add error handling in this method. For example, check to make sure the query returns exactly one result. Also, this method appears to be susceptible to SQL injection: http://en.wikipedia.org/wiki/SQL_injection

answered Sep 9, 2013 at 5:16

Doug Lamb

4753 silver badges7 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Howard Hee Over a year ago

If I have join with other table, what should I put into Item("")?

Collectives™ on Stack Overflow

Get SQL single value from query as String

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related