Insertion of data into database using php

Question

I'm new to php I have created a php form that will insert data into the database my database name is Emp and the table name is info. I'm inserting using PDO. I have written a code to do this and it is getting executed without catching any errors, but the database is still empty. I have posted my code below please tell me what I'm doing wrong.

<?php
    try{
        echo $_POST['name'].", ".$_POST['age'].", ".$_POST['email'].", ".$_POST['name'].", ".$_POST['country'].", ". $_POST['city'] ;
        $user="root";
        $pass="root123";
                    $con=new PDO('mysql:host=localhost;dbname=Emp', $user, $pass);
        $con->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
        $con->setAttribute(PDO::ATTR_EMULATE_PREPARES, false);
        $con->beginTransaction();
        //echo "INSERT INTO info(Empid,Ename,Age,Email,Country,City,Salary) VALUES('".$_POST['eid']."','".$_POST['name']."','".$_POST['age']."','".$_POST['email']."','".$_POST['country']."','".$_POST['city']."','".$_POST['salary']."')";
        $num=$con->exec("INSERT INTO info(Empid,Ename,Age,Email,Country,City,Salary) VALUES('".$_POST['eid']."','".$_POST['name']."','".$_POST['age']."','".$_POST['email']."','".$_POST['country']."','".$_POST['city']."','".$_POST['salary']."')");
        echo "<br>".$num." row added succesfully"; // this is displayed when I execute this but database is empty.
    }
    catch(Exception $e)
    {
        echo 'Exception -> ';
        var_dump($e->getMessage());
    }
    ?>

what happens when you run this query directly into your database? — zzlalani
– zzlalani, Commented Sep 11, 2013 at 5:32
You're starting a transaction with beginTransaction(), but it won't appear on the database until you finalise the transaction with commit() — user1864610
– user1864610, Commented Sep 11, 2013 at 5:32
Additional note: please read the paragraph on PDO and bound parameters in this document to avoid SQL injectin: phptherightway.com/#databases — herrjeh42
– herrjeh42, Commented Sep 11, 2013 at 5:49

Hanky Panky · Accepted Answer · 2013-09-11 05:33:21Z

2

Since you have used beginTransaction(), you have to commit the changes. Add

$con->commit();

Reference: PHP Manual

Note: Even though you are using PDO, you are still interpolating HTTP Request values without sanitization, that could be bad

answered Sep 11, 2013 at 5:33

Hanky Panky

46.9k9 gold badges76 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Hanky Panky · Accepted Answer · 2013-09-11 05:47:00Z

1

you either have to commit or rollback the transaction ..

changes made to the database via the PDO transactions are not committed until you end the transaction by calling PDO::commit() or Calling PDO::rollBack()

<?php
try{
    echo $_POST['name'].", ".$_POST['age'].", ".$_POST['email'].", ".$_POST['name'].", ".$_POST['country'].", ". $_POST['city'] ;
   ...
  $con->beginTransaction();
  ....
   $con->commit();
}
catch(Exception $e)
{
    echo 'Exception -> ';
    var_dump($e->getMessage());
     $con->rollBack();
}
?>

edited Sep 11, 2013 at 5:47

Hanky Panky

46.9k9 gold badges76 silver badges95 bronze badges

answered Sep 11, 2013 at 5:33

bipen

36.6k9 gold badges51 silver badges62 bronze badges

1 Comment

zzlalani Over a year ago

It doesn't matter btw but you have typo here $conn->commit(); and also we have the very same code in our answers. weird :/

zzlalani · Accepted Answer · 2013-09-11 05:38:32Z

1

All you need to do is to commit and/or rollBack your code

<?php
    try{
        .
        . code
        .
        $con->beginTransaction();
        .
        . code
        .
        $num=$con->exec("INSERT INTO info (Empid,Ename,Age,Email,Country,City,Salary) VALUES('".$_POST['eid']."','".$_POST['name']."','".$_POST['age']."','".$_POST['email']."','".$_POST['country']."','".$_POST['city']."','".$_POST['salary']."')");
        $con->commit(); // This is missing
    }
    catch(Exception $e)
    {
        var_dump($e->getMessage());
        $con->rollBack(); //  And this is missing
    }
?>

answered Sep 11, 2013 at 5:38

zzlalani

24.6k16 gold badges48 silver badges73 bronze badges

Collectives™ on Stack Overflow

Insertion of data into database using php

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related