PHP: Not connecting to database

Question

I have a database called message, with a table called user in it. The table, 'user' has five columns, user_id which is the primary key and auto increments. Then is the first name last name username and password. But when i press the submit button, it shows me error connecting. Cannot find the error!

What could it be?

<!DOCTYPE html>
<html>
<head>
<script src="jquery.js"></script>
<title> Create Account
</title>

</head>

<body>
<?php

$dbc=mysqli_connect('localhost', 'root', '', 'message') or die("Error");
if(isset($_POST['submit']))
{

    if($_POST['password']==$_POST['repassword'])
    {
        $fname=$_POST['fname'];
        $lname=$_POST['lname'];
        $username=$_POST['username'];
        $password=$_POST['password'];
        $password_hash=sha1($password);
        $query="INSERT INTO user (fname, lname, username, password)"."VALUES('$fname', '$lname', '$username', '$password_hash')";
        $result=mysqli_query($dbc, $query) or die("Error Connecting");
        echo "Account Created!";
        mysqli_close($dbc);


    }
    else
    {
        echo "Passwords do not match";
    }
}

?>

Have you selected table user via mysqli_select_db? I couldn't see it ya! — ekremkaraca
– ekremkaraca, Commented Sep 11, 2013 at 8:57
Not directly related to the problem, but this is very misleading for users reporting bugs and you debugging/asking for help as well: If mysqli_query() fails you should report it as "Query failed" or "Couldn't create account". It should never state "Error Connecting", because at that point in time you're either connected already or it failed above ("Errror"). — Mario
– Mario, Commented Sep 11, 2013 at 8:58
Make sure your database server is running (and if it is using default port), try using mysqli_connect_error() to see if there is something more informative. Src: php.net/manual/en/mysqli.construct.php — porfiriopartida
– porfiriopartida, Commented Sep 11, 2013 at 9:02
put the insert query inside try catch statment to see whats the real php exception ... i think that will give u the specific problem — Leo Bali
– Leo Bali, Commented Sep 11, 2013 at 9:04

Funk Forty Niner · Accepted Answer · 2013-09-11 12:32:51Z

1

You need to add "" around the fields you are about to insert.

You presently have:

$query="INSERT INTO user (fname, lname, username, password)"."VALUES('$fname', '$lname', '$username', '$password_hash')";

Do this instead:

$query='INSERT INTO user (fname, lname, username, password) '.
   'VALUES("'.$fname.'", "'.$lname.'", "'.$username.'", "'.$password_hash.'")';

edited Sep 11, 2013 at 12:32

Funk Forty Niner

74.2k14 gold badges71 silver badges146 bronze badges

answered Sep 11, 2013 at 9:00

davidkonrad

85.7k17 gold badges211 silver badges273 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Ivan Yonkov Over a year ago

They are interpolated in nested quotes

Grmn Over a year ago

Better yet, use backticks and there is no need for "."VALUES remove the "." and backtick".$fname."+backtick, and for debug, echo $query, copy paste the query in your phpMyAdmin and see what error it gives you.

Kevin Desai Over a year ago

It worked thanks! I just need to clear my firm after the account is created! How can I do that?

davidkonrad Over a year ago

gr8! Your firm ..? Dont quite follow.

Kevin Desai Over a year ago

Clear the form** Sorry!

Liam Allan · Accepted Answer · 2013-09-11 09:03:34Z

1

change your insert query to

$query="INSERT INTO user (fname, lname, username, password) VALUES('".$fname."', '".$lname."', '".$username."', '".$password_hash."')";

answered Sep 11, 2013 at 9:03

Liam Allan

1,1151 gold badge8 silver badges13 bronze badges

1 Comment

Kevin Desai Over a year ago

Thanks it worked! I would like to know why do we have to write in this format? Cause I guess the earlier one was correct as well.

Collectives™ on Stack Overflow

PHP: Not connecting to database

2 Answers 2

5 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related