Rspec testing for duplicates?

Question

I am trying to test for "A product can list users that have reviewed it without duplicates"

this is what my test looks like

product_spec.rb

describe Product do

let!(:product) { Product.create } 
.
.#other test
.

  it "can list users that review it without duplicates" do
   product.reviews.create({user_id: 1, review: "test"})
  product.reviews.create({user_id: 1, review: "test2"})

   product.user.uniq.count.should eq(1)
  end
end

terminal result

1) Product can list users that review it without duplicates
 Failure/Error: product.reviews.create({user_id: 1, review: "test"})
 ActiveRecord::RecordNotSaved:
   You cannot call create unless the parent is saved
 # ./spec/models/product_spec.rb:49:in `block (2 levels) in <top (required)>'

You need to share more of your code, including anything involved in the creation of product in your test. — Peter Alfvin
– Peter Alfvin, Commented Sep 11, 2013 at 13:02

BroiSatse · Accepted Answer · 2013-09-11 13:06:56Z

1

The problem is in this line:

product.save.reviews.create

Save returns boolean whether object has been saved successfully or not. You need to split this into two lines:

product.save
product.reviews.create

edited Sep 11, 2013 at 13:06

answered Sep 11, 2013 at 12:56

BroiSatse

44.8k8 gold badges63 silver badges89 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

gotva Over a year ago

and I suggest to use save! and create! to catch if some records can not be saved because of validation issues.

Jakob S · Accepted Answer · 2013-09-11 14:33:18Z

0

You are trying to create a Review on a Product that hasn't been saved with:

product.reviews.create()

I'm guessing product isn't valid, thus it hasn't been saved by

let!(:product) { Product.create }

which simply returns the invalid object if create fails.

You should

Use create! to make sure you notice when saving the object fails (it'll raise an exception if there's a validation error).
Make sure your Product can be created with the data, you provide it.

edited Sep 11, 2013 at 14:33

answered Sep 11, 2013 at 13:23

Jakob S

20.2k3 gold badges43 silver badges38 bronze badges

2 Comments

medBouzid Over a year ago

you say : (it'll raise an exception instead of returning false), "create" don't return false if saving object fails, it return an invalid object model instead

Jakob S Over a year ago

Indeed. Corrected my answer.

Collectives™ on Stack Overflow

Rspec testing for duplicates?

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related