function inside FOR LOOP execute only once

Question

i have an array of email add that needs to be verified. When I call the function during iteration, loop stops after first iteration and does not proceed over entire array. and the return value.

$num contains 6, and $email compose of ([email protected],[email protected],[email protected], [email protected], [email protected],[email protected]) the only valid and registered email are [email protected] and [email protected], but im only getting the [email protected] which is the last.

  function get_email_verification(){
        $num = count($this->get_payqucker_emails());
        $email = $this->get_payqucker_emails();
        if ($num){
            for($i=0; $i < $num; $i++){
                $api_request_url = "http://api.payquicker.com/api/IsActiveAccount";
                $param = "email=".$email[$i];
        $result_request =  $this->do_request($api_request_url, $param, 'GET', 'json');   
            }
        }
        else {
            echo "All payee emails are already registered to Payquicker";
        }
         return $result_request ; 

    }

The do_request function will pause a json/xml value to (GET/POST) in Payquicker APIs

Not a direct problem but the code would run sooooo smoother if you'd do $num = count($email). There is no need to call the function twice. — Jakub Kania
– Jakub Kania, Commented Sep 12, 2013 at 8:56
this only execute once $result_request = $this->do_request($api_request_url, $param, 'GET', 'json'); — ArkNet
– ArkNet, Commented Sep 12, 2013 at 9:01
@ArkNet How do you know code inside the loop executes only once? — Konstantin
– Konstantin, Commented Sep 12, 2013 at 9:03
you get 1 return value you overwriting it try, $result_request[] — cske
– cske, Commented Sep 12, 2013 at 9:08

cske · Accepted Answer · 2013-09-12 09:23:15Z

1

Use foreach:

function get_email_verification(){
            $result_request = array();
            $api_request_url = "http://api.payquicker.com/api/IsActiveAccount";
            foreach ($this->get_payqucker_emails() as $email) {

                    $param = "email=".$email;
                    $result_request[] =  $this->do_request($api_request_url, $param, 'GET', 'json');
            }
            if (empty($result_request)) {
                echo "All payee emails are already registered to Payquicker";
            }
            return $result_request;     
     }

edited Sep 12, 2013 at 9:23

answered Sep 12, 2013 at 9:07

cske

2,2334 gold badges27 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

itachi Over a year ago

what difference will it make? (between for and foreach)

ArkNet Over a year ago

@cske Thank you im getting the two email.

Vahid Hallaji Over a year ago

Move $api_request_url = ... before foreach. Not clean!

ArkNet Over a year ago

@hallaji yes i move it above as that is constant var.

cske Over a year ago

@itachi: array keys can be anything, php arrays naturally hashes

Collectives™ on Stack Overflow

function inside FOR LOOP execute only once

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related