Should I use jQuery.inArray()?

Question

I'm doing very frequent searches in arrays of objects and have been using jQuery.inArray(). However, I'm having speed and memory issues and one of the most called methods according to my profiler is jQuery.inArray(). What's the word on the street about its performance? Should I switch to a simple for loop?

My specific function is:

function findPoint(point, list)
{
  var l = list.map(function anonMapToId(p) { return p.id });
  var found = jQuery.inArray(point.id, l);
  return found;
}

Is perhaps list.map() is more to blame?

Can I ask how you are identifiying that this is a performance issue? (just out of curiosity) — calumbrodie
– calumbrodie, Commented Mar 24, 2011 at 14:34
Fair enough I didn't notice that the question was over a year old... O.K do you even remember what you meant by according to 'my profiler'? What profiler are you using? — calumbrodie
– calumbrodie, Commented Mar 27, 2011 at 16:33

BenMorel · Accepted Answer · 2014-01-07 12:34:24Z

15

Well internally inArray makes a simple loop, I would recommend you to check if there is a native Array.prototype.indexOf implementation and use it instead of inArray if available:

function findPoint(point, list) {
  var l = list.map(function anonMapToId(p) { return p.id });
  var found = ('indexOf' in Array.prototype) ? l.indexOf(point.id)
                                             : jQuery.inArray(point.id, l);
  return found;
}

The Array.prototype.indexOf method has been introduced in browsers that implement JavaScript 1.6, and it will be part of the ECMAScript 5 standard.

Native implementations are way faster than non native ones.

edited Jan 7, 2014 at 12:34

BenMorel

37k52 gold badges208 silver badges339 bronze badges

answered Dec 10, 2009 at 20:18

Christian C. Salvadó

831k185 gold badges929 silver badges845 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

ICodeForCoffee Over a year ago

jQuery already does this automatically. forum.jquery.com/topic/inarray (It's on the first comment to the post) As an aside, IE8 doesn't implement Array.prototype.indexOf.

JTE Over a year ago

'inArray' sounds more like it returns a boolean, but it does not. Do the next developer a favor and use 'indexOf'.

Loudenvier Over a year ago

I think it will defeat the purpose of "speed" if you don't cache the result of the test for the existence of the indexOf method. I also believe that jQuery will do that for you...

Raynos · Accepted Answer · 2011-03-24 14:31:42Z

3

What you really want is a Array.prototype.filter.

function findPoint(point, list)
{
     return list.filter(function anonFilterToId(p) { 
         return p.id === point.id; 
     }).length > 0;
}

answered Mar 24, 2011 at 14:31

Raynos

170k57 gold badges359 silver badges399 bronze badges

Comments

xtofl · Accepted Answer · 2009-12-10 20:19:33Z

2

Even is the inArray function were slow, you're still creating a full new array for every search. I suppose it would be better to redesign this search, by e.g. creating the id-list before finding the points, and using that one to search into:

answered Dec 10, 2009 at 20:19

xtofl

41.7k13 gold badges112 silver badges203 bronze badges

Comments

Guillaume Aversa · Accepted Answer · 2011-03-24 14:20:52Z

2

I'm doing a join of the array to turn it into a string and avoid the loop section like this :

var strList = ","+array.join(",")+",";
return strList.indexOf(","+search+",") !== -1 ? true : false;

if the array is huge, it can hurt, but for a small list it's much faster than the loop solution

PS I'm adding an ending coma to avoid look a like

edited Mar 24, 2011 at 14:20

answered Mar 24, 2011 at 14:14

Guillaume Aversa

1711 silver badge5 bronze badges

1 Comment

Rochelle C Over a year ago

This may not be the prettiest way but it eliminated the "Stop running this script" error I was getting with inArray in IE8.

Tony Web · Accepted Answer · 2012-03-09 18:47:59Z

1

I always use lastIndexOf when I want to know if there's a string in my array. So, its something like this:

var str = 'a';
var arr = ['a','b','c'];

if( arr.lastIndexOf(str) > -1){ 

      alert("String " + str + " was found in array set");

} else {

      alert("String " + str + " was not found");

}

If you just want to find a string in array, I do believe this might be the best practice.

edited Mar 9, 2012 at 18:47

user142162

answered Mar 9, 2012 at 16:22

Tony Web

111 bronze badge

Collectives™ on Stack Overflow

Should I use jQuery.inArray()?

5 Answers 5

3 Comments

Comments

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

3 Comments

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related