how to use onclick function when image button clicked?

Question

i am trying to call a function when clicking an image button below but the function never fires. could any one tell me what i am doing wrong? is there any good jsfiddle type site that i show demo ?

    <script>
    function deleteLike(a,b)
    {
    alert("PageLink:"+a+"\nId:"+b);

    }
    </script>




    <?php

$i="23";
$pageLink="http://www.nba.com";

        echo '<div id="'.$i.'" style="float: right; padding: 5px 2px 2px;"> <img class="liker" onclick="deleteLike("'.$PageLink.'","'.$i.'")" src="http://cultureslurp.com/wp-content/uploads/2011/09/Facebook-Like-Button.jpg" border="0"></div>';

      ?>

You should read about unobtrusive javascript, your code is considered bad practice. It also makes things easier. See learn.jquery.com — pdu
– pdu, Commented Sep 18, 2013 at 8:05

Sudhir Bastakoti · Accepted Answer · 2013-09-18 08:12:39Z

1

try doing:

echo '<div id="'.$i.'" style="float: right; padding: 5px 2px 2px;"> <img class="liker" onclick="deleteLike(\''.$PageLink.'\',\''.$i.'\')" src="./liked.png" border="0"></div>';

answered Sep 18, 2013 at 8:12

Sudhir Bastakoti

100k15 gold badges163 silver badges169 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

sskoko · Accepted Answer · 2013-09-18 08:08:02Z

0

You can't have

onclick="deleteLike("");"

Instead use:

onclick="deleteLike('');"

Like this:

echo "<div id='$i' style='float: right; padding: 5px 2px 2px;'> <img class='liker' onclick=\"deleteLike('$PageLink','$i');\" src='http://cultureslurp.com/wp-content/uploads/2011/09/Facebook-Like-Button.jpg' border='0'></div>";

answered Sep 18, 2013 at 8:08

sskoko

8397 silver badges18 bronze badges

3 Comments

user1788736 Over a year ago

thanks for reply. how to declare variables inside it so it get passsed to function if i using your method ?

sskoko Over a year ago

Just changed my answer with proper link.

sskoko Over a year ago

If you use echo " " instead of echo ' ' you can store variables inside quotes. It makes you code easier to read without confusing .'\',\''.

Pi Wi · Accepted Answer · 2013-09-18 08:20:46Z

0

Make your life easy and use jQuery and implement best practices. Look at this code. Works also for people without javascript enabled!

<script src="http://code.jquery.com/jquery-1.10.1.min.js"></script>
<script>
    $(function(){
        $('.a-liker').click(function(e){
            e.preventDefault();
            alert("PageLink: " + $(this).attr('href'));
            alert("Id: " + $(this).parent().attr('id'));
        });
    });
</script>

<div id="23" style="float: right; padding: 5px 2px 2px;">
    <a href="http://www.nba.com" class="a-liker">
        <img class="liker" src="./liked.png" border="0">
    </a>
</div>

answered Sep 18, 2013 at 8:20

Pi Wi

1,0851 gold badge11 silver badges20 bronze badges

Collectives™ on Stack Overflow

how to use onclick function when image button clicked?

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related