href working instead of javascript

Question

I am having an issue with the a href="#" still working when the link is clicked - I can see the console.log() before the page changes - why is it doing this?

HTML:

<a href="#" id="brands_by_category_change_name_btn" class="btn btn-primary" >Save</a>

JS:

        $('body').on("click", "#brands_by_category_change_name_btn", function () {

            var self = $(this);
            var id = $("#product_name_head").data("productid");
            var cat_id = $(".product_category_selector").data("id");

            var url = $("#manufacturers_table").data("infourl");

            var state = "0";
            if(self.is(":checked"))
            {
                state = "1";
            }
            var data_array = { 
                    id : id, 
                    cat_id : cat_id, 
                    state : state
                };

                console.log(url);

            //ajaxCall(url, data_array, null, "reload_selected_product_categories");

        });

Check out this similar question and the answers for best practices. stackoverflow.com/questions/134845/… — Meximize
– Meximize, Commented Sep 19, 2013 at 20:45

Gena Moroz · Accepted Answer · 2013-09-19 20:41:32Z

7

You should pass event parameter to function. And do. Event.preventDefault() it will stop link from native behavior.

answered Sep 19, 2013 at 20:41

Gena Moroz

9545 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

andrew · Accepted Answer · 2013-09-19 20:43:37Z

0

Adding return false; at the end of the function will fix the problem

answered Sep 19, 2013 at 20:43

andrew

9,6039 gold badges36 silver badges62 bronze badges

Comments

jotaen · Accepted Answer · 2013-09-19 20:44:58Z

0

Add a return false; at the end of your event-handling code. I would do it that way:

$("#brands_by_category_change_name_btn").click( 

  // your code...

  return false;

});

answered Sep 19, 2013 at 20:44

jotaen

7,0791 gold badge14 silver badges24 bronze badges

Collectives™ on Stack Overflow

href working instead of javascript

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related