C# Creating an object within a class

Question

I'm making a map loading system that uses chunks so that the entire map data doesn't have to be loaded at once.

I have a "World" class, and within that class I'm creating an instance of a class called "ChunkManager".

I'm unsure if creating an instance inside another class is a good idea/considered a "normal" thing to do etc. I've not been able to find anything about this while searching the internet.

So my question is: Should I be creating an instance of a class within a class in the way I have, or will there be problems with doing it this way?

Here is my code, if it's relevant:

class World
{

    public string WorldName { get; set; }
    ChunkManager chunkManager = new ChunkManager();


    public World(string worldName)
    {
        WorldName = worldName;

    }

    public void AddChunk(int X, int Y)
    {
        //Plus other validation code here that I didn't paste
        chunkManager.AddChunk(X, Y);
    }
}

And ChunkManager:

class ChunkManager
{
    public int TotalGeneratedChunks { get; private set; }

    private List<Chunk> ChunkList = new List<Chunk>();

    public bool CheckIDExists(int IDToCheck)
    {
        foreach (Chunk i in ChunkList)
        {
            if (i.UniqueID == IDToCheck)
            {
                return true;
            }
        }

        return false;
    }

    public void AddChunk(int X, int Y)
    {
        ChunkList.Add(new Chunk(TotalGeneratedChunks++, X, Y));

    }
}

If you had read any code at all in your travels you would have seen this exact thing done in every bit of code you saw. When you something as simple as creating/initialising a new string you are "creating an object within a class" as you put it. — slugster
– slugster, Commented Sep 20, 2013 at 3:19
No problem with doing this. But using dependency injection would be a good idea as well. — Brent Mannering
– Brent Mannering, Commented Sep 20, 2013 at 3:21
There is no issue with this approach as long as you recognize you're tightly coupling your class to that implementation of ChunkManager. Remember: New is Glue! ardalis.com/new-is-glue — ssmith
– ssmith, Commented Sep 22, 2017 at 12:12

Ian Mercer · Accepted Answer · 2013-09-20 04:40:26Z

4

Your code is fine BUT if either class grows to be more complex and you want to be able to test them independently you should instead define an interface IChunkmanager and inject an instance of ChunkManager into World:

class World
{

    public string WorldName { get; set; }
    private readonly IChunkManager chunkManager;


    public World(string worldName, IChunkManager chunkmanager)
    {
        this.chunkManager = chunkManager;
        ...

With this approach you can use a mocking framework to inject a mock IChunkManager and can test the World class independently.

In general classes should be loosely coupled. As soon as you new-up an instance of another class within a class you have tightly-bound them in a way that makes it hard to test them independently (or to reuse them in different situations).

answered Sep 20, 2013 at 4:40

Ian Mercer

39.4k8 gold badges103 silver badges139 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user9993 Over a year ago

~2 years later and after I've improved my knowledge a lot more and I understand dependency injection and interfaces, I understand your answer a lot more. Thanks!

Tejas Sharma · Accepted Answer · 2013-09-20 03:24:37Z

2

It's perfectly fine to create an instance of a class inside another. chunkManager is what is known as a field and the syntax for initializing it inline along with its declaration is called an initializer. You can find more information on initializers and how they are different from initializing via the constructor in this blog series by Eric Lippert

Part 1 Part 2

It might some times be a better idea to initialize fields via the constructor though as this lets you use dependency injection (parameter injection to be precise) which can greatly improve the testability and modularity of your code. If you're interested in learning more about dependency injection I suggest purchasing and reading this book.

edited Sep 20, 2013 at 3:24

answered Sep 20, 2013 at 3:19

Tejas Sharma

3,45024 silver badges35 bronze badges

Comments

PlausibleSarge · Accepted Answer · 2013-09-20 03:33:26Z

1

Standard practice is to set values inside the constructor because it allows for dependency injection and makes modifying the constructor to use an argument trivially easy.

answered Sep 20, 2013 at 3:33

PlausibleSarge

2,2531 gold badge13 silver badges13 bronze badges

Comments

DevEstacion · Accepted Answer · 2013-09-20 04:27:57Z

0

If you are going to create a lot of World, i suggest creating an Abstract base that implements the ChunckManager.

That way you can leverage the use of base class, promote code reuse. You can also make your ChunkManager singleton since it only needs to be used by the base, and then use a method to actually instantiate the ChunkManager if you need specific properties from maps.

Use DI to pass the prop from child to base to instantiation of the ChunkManager

answered Sep 20, 2013 at 4:27

DevEstacion

1,9771 gold badge14 silver badges29 bronze badges

Comments

sara Sodagari · Accepted Answer · 2013-09-20 05:18:59Z

0

yes you can use one class type in another class its like one of filed on this class like when you use string a=new string() you use an object of class string its normal code

answered Sep 20, 2013 at 5:18

sara Sodagari

4231 gold badge9 silver badges23 bronze badges

Collectives™ on Stack Overflow

C# Creating an object within a class

5 Answers 5

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related