A foreach loop in a while loop

Question

I'm trying to convert wordpress tags (and other input) to html classes. First I query the posts, set them in a while loop and in this while loop I convert the tags to usefull classes. I've got this right now:

 <?php while ($query->have_posts()) : $query->the_post(); 


    $posttags = get_the_tags();
    if ($posttags) {
      foreach($posttags as $tag) {
        $thetags =  $tag->name . ''; 
        echo $the_tags;

        $thetags = strtolower($thetags);


        $thetags = str_replace(' ','-',$thetags);
        echo $thetags;


      }
   }
    ?>

    <!-- Loop posts -->         
    <li class="item <?php echo $thetags ?>" id="<?php the_ID(); ?>" data-permalink="<?php the_permalink(); ?>">

<?php endwhile; ?>

Now what's the problem:

The first echo, echoes the tags like: Tag 1 Tag 2. The second echoes it like tag-1tag-2, what is not what I want either because there are no spaces between every tag. Thereby is only the last tag shown in the html class, because it's not in the foreach loop.

What do I want: I want to have all related tags in the html class. So the end result must be like:

<li class="item tag-1 tag-2 tag-4" id="32" data-permalink="thelink">

However if I would put the list item in the foreach loop, I would get a <li> item for every tag. How to do this properly? Thanks!

You have several tags, so use array to store multiple tags

HTML Man
– HTML Man

2013-09-25 13:14:56 +00:00
Commented Sep 25, 2013 at 13:14 — HTML Man
– HTML Man, Commented Sep 25, 2013 at 13:14

Kasper Sanguesa-Franz · Accepted Answer · 2013-09-25 13:09:44Z

1

i Would do something like this (use a array instead of that and then use implode to get it with spaces between it :)

<?php while ($query->have_posts()) : $query->the_post(); 

$tags = array(); // a array for the tags :)
$posttags = get_the_tags();
if (!empty($posttags)) {
  foreach($posttags as $tag) {
    $thetags =  $tag->name . ''; 
    echo $the_tags;

    $thetags = strtolower($thetags);


    $thetags = str_replace(' ','-',$thetags);
    $tags[] = $thetags;

    echo $thetags;


  }
}
?>

<!-- Loop posts -->      
<li class="item <?= implode(" ", $tags) ?>" id="<?php the_ID(); ?>" data-permalink="<?php the_permalink(); ?>">

answered Sep 25, 2013 at 13:09

Kasper Sanguesa-Franz

6175 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Kasper Sanguesa-Franz Over a year ago

you can as h2ooooooo showed remove some of the echos and put some of the things on one line (you dont even need this ( $thetags = $tag->name . ''; ) since you can just do this $thetags = $tag->name;

h2ooooooo · Accepted Answer · 2013-09-25 13:03:37Z

1

Use an array instead, and then implode it. Do yourself a favour and use brackets in your while clause instead (if you prefer it for readability - I know I do in this case):

<?php
    while ($query->have_posts()) {
        $query->the_post(); 

        $posttags = get_the_tags();

        $tags = array(); //initiate it
        if ($posttags) {
            foreach($posttags as $tag) {
                $tags[] = str_replace(' ','-', strtolower($tag->name)); //Push it to the array
            }
        }
        ?>
            <li class="item<?php echo (!empty($tags) ? ' ' . implode(' ', $tags) : '') ?>" id="<?php the_ID(); ?>" data-permalink="<?php the_permalink(); ?>">
        <?php
    }
?>

answered Sep 25, 2013 at 13:03

h2ooooooo

39.6k8 gold badges70 silver badges107 bronze badges

Collectives™ on Stack Overflow

A foreach loop in a while loop

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related