Trouble with simple password program -- Java

Question

I was doing some programming one night and I ran into a problem. It seems the if statement in the action listener for my button is not being picked up. I am farely new to programming so I hope it is not anything too obvious Any suggestions? Here's the code:

import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.*;
import java.util.*;
import javax.swing.*;

public class Login extends JFrame implements ActionListener {
JTextField tfUsername, tfPassword;
JLabel jlUser, jlPass;
JTextArea tarea;
JButton bLogin;

public Login(){
    JFrame frame = new JFrame("Login Test");
    JPanel panel = new JPanel();
    jlUser = new JLabel("Username");
    tfUsername = new JTextField(20);
    jlPass = new JLabel("Password");
    tfPassword = new JTextField(20);
    bLogin = new JButton("Login");
    tarea = new JTextArea();

    frame.setSize(335,150);
    frame.add(panel);
    panel.add(jlUser);
    panel.add(tfUsername);
    panel.add(jlPass);
    panel.add(tfPassword);
    panel.add(bLogin);
    panel.add(tarea);
    bLogin.addActionListener(this);
    frame.setResizable(true);
    frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    frame.setVisible(true);
}


public static void main(String[] args) {
new Login();

}


@Override
public void actionPerformed(ActionEvent e) {
    // TODO Auto-generated method stub
    if(e.getSource() == bLogin){
        String user = tfUsername.getText();
        String pass = tfPassword.getText();
        String be = "hi";

                    if(pass == be){
            tarea.setText("Successful");
        }
}

}

MadProgrammer · Accepted Answer · 2013-09-26 00:41:05Z

6

The problem is with how you are comparing the pass and be Strings

if (pass == be) {
    tarea.setText("Successful");
}

This is comparing the Object references, not their content, which will always be false...Instead you should be using .equals

if (pass.equals(be)) {
    tarea.setText("Successful");
}

This will do a case sensitive comparison. If required, you can also use .equalsIgnoreCase where the case does not matter

For passwords, you should be using JPasswordField and storing the password in a char array, as String values are easier to pick out of memory.

This would then require you to use Arrays.equals(char\[\], char\[\]) instead

See How to use Password Fields for more details...

answered Sep 26, 2013 at 0:41

MadProgrammer

348k22 gold badges243 silver badges379 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

LynAs · Accepted Answer · 2013-09-26 00:48:57Z

1

So far what i can see is the String compare error. Post the error log to see if there is any other error. In the string match try

if (pass.equals(be)) {
    tarea.setText("Successful");
}

You can also use compareto function as well to check String

Also gettext for pass is not very secured

edited Sep 26, 2013 at 0:48

answered Sep 26, 2013 at 0:43

LynAs

6,58714 gold badges51 silver badges87 bronze badges

3 Comments

LynAs Over a year ago

u are faster, congrats

MadProgrammer Over a year ago

Sorry, it's early and I've had little sleep, so I'm a little cynical. I'm certainly not against people expanding on answers or providing additional points of view, but it does get annoying when people populate the questions with the same answer - IMHO :P

MadProgrammer Over a year ago

Apologies, I'm having a rant, and you just got in the way :P

Collectives™ on Stack Overflow

Trouble with simple password program -- Java

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related