Php upload file

Question

The code looks like this:

html

<form action="contact.php" method="post" enctype="multipart/form-data" onsubmit="return Validare();">

    <input type="text" name="nume" value="Nume" class="contact" id="Nume" onclick="if(this.value=='Nume')this.value='';" onblur="if(this.value.replace(/^\s+|\s+$/g,'')=='')this.value='Nume'" /><font color="red">*</font><br />
            <input type="text" name="email" value="Email" class="contact" id="Email" onclick="if(this.value=='Email')this.value='';" onblur="if(this.value.replace(/^\s+|\s+$/g,'')=='')this.value='Email'" /><font color="red">*</font><br />
            <input type="text" name="telefon" value="Telefon" class="contact" id="Telefon" onclick="if(this.value=='Telefon')this.value='';" onblur="if(this.value.replace(/^\s+|\s+$/g,'')=='')this.value='Telefon'" /><br />
            <textarea name="mesaj" rows="10" class="contact" id="Mesaj" onclick="if(this.value=='Mesaj')this.value='';" onblur="if(this.value.replace(/^\s+|\s+$/g,'')=='')this.value='Mesaj'">Mesaj</textarea>

<input type="file" name="file[]" />
<input type="file" name="file[]" />
<input type="file" name="file[]" />
<input type="submit" value="Trimite" />
</form>

php

for($i=0; $i<3; $i++){
if($_FILES["file"]["size"][$i] > 0){
    $rand = rand(10000, 99999);
    $name = $rand.rand(10000, 99999).$_FILES["file"]["name"][$i];
            $tmp_name = $_FILES["file"]["tmp_name"][$i];
    $target_path_big = "http://biroutraduceri.net/fisiere/".$name;
    move_uploaded_file($tmp_name, "fisiere/".$name);
}
}

javascript

<script>
function Validare(){
    if(document.getElementById("Nume").value.replace(/^\s+|\s+$/g,'') == "" || document.getElementById("Nume").value.replace(/^\s+|\s+$/g,'') == "Nume"){
        alert("Numele nu este valid!");
        return false;
    }
    if(document.getElementById("Email").value.replace(/^\s+|\s+$/g,'') == "" || document.getElementById("Email").value.replace(/^\s+|\s+$/g,'') == "Email"){
        alert("Email-ul nu este valid!");
        return false;
    }
    if(document.getElementById("Mesaj").value.replace(/^\s+|\s+$/g,'') == "" || document.getElementById("Mesaj").value.replace(/^\s+|\s+$/g,'') == "Mesaj"){
        alert("Mesajul nu este valid!");
        return false;
    }
    return true;
}
</script>

When I press submit nothing happen. The file isn't uploaded.

Where I'm wrong???

can you post Validare() too? It should return true to let your form submit. — catchmeifyoutry
– catchmeifyoutry, Commented Dec 14, 2009 at 20:27
$tmp_name = $_FILES["file"]["tmp_name"][$i]; This is from the for loop. — Emanuel
– Emanuel, Commented Dec 14, 2009 at 20:36

Peter Lindqvist · Accepted Answer · 2009-12-14 20:46:59Z

2

Your PHP code has an error, the $tmp_name is never set.

Corrected code

for($i=0; $i<3; $i++){
    if($_FILES["file"]["size"][$i] > 0){
        $rand = rand(10000, 99999);
        $name = $rand.rand(10000, 99999).$_FILES["file"]["name"][$i];
        $target_path_big = "http://biroutraduceri.net/fisiere/".$name;
        move_uploaded_file($_FILES["file"]["tmp_name"][$i], "fisiere/".$name);
    }
}

answered Dec 14, 2009 at 20:46

Peter Lindqvist

10.2k3 gold badges44 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

DrYak Over a year ago

And is the target directory "is_writeable" ? Together with all the necessary unix file permission ? For example, the directory could be chmoded to 0775 "rwxrwxr-x" with a group set to "www" or "apache" (or whatever the PHP process is running as).

Brad · Accepted Answer · 2009-12-14 20:29:32Z

1

$tmp_name is never initialized to anything.

$tmp_name should be set equal to $_FILES['file']['tmp_name'][$i];

answered Dec 14, 2009 at 20:29

Brad

5,4681 gold badge36 silver badges56 bronze badges

3 Comments

Peter Lindqvist Over a year ago

@Lucas Which part are you referring to?

Brad Over a year ago

It was a comment that I had removed.

Powerlord Over a year ago

@Peter Lindqvist: Yes, it's one of my biggest complaints with the "not marked as edited if done within 5 minutes" thing.

jeroen · Accepted Answer · 2009-12-14 21:15:44Z

0

Could be a permission problem, does your script have permission to write in "fisiere/".$name and is "fisiere/".$name really where you think it is? You might want to use an absolute path.

Edit: You cannot write an image to a http url, you need to write it to a local file-path and you need to make sure php has permissions to write to that path / directory

edited Dec 14, 2009 at 21:15

answered Dec 14, 2009 at 20:49

jeroen

91.8k22 gold badges117 silver badges132 bronze badges

1 Comment

Emanuel Over a year ago

I've try even with "http : // url / fisiere /"; . $name, but nothing.

streetparade · Accepted Answer · 2009-12-14 20:31:36Z

0

You realy dont need the onsubmit="return Validare();" and it is even written wrong. and move_uploaded_file($_FILES['file']['tmp_name'], $target_path)) is the correct code for

answered Dec 14, 2009 at 20:31

streetparade

33k39 gold badges106 silver badges123 bronze badges

3 Comments

Brad Over a year ago

You still need the index at the end of $_FILES['file']['tmp_name'] so that the correct file is referenced.

Emanuel Over a year ago

I need this onsubmit="return Validare();" for validation.

streetparade Over a year ago

this is true and valid in most cases, i agree :)

DrYak · Accepted Answer · 2009-12-14 20:36:59Z

0

You forgot to set up the variable $tmp_name. As in $tmp_name = $_FILES["file"]["tmp_name"][$i]; Otherwise, it seems ok as per my own tests.

Otherwise, throw in a print_r($_FILES); before your "for" loop, a couple more prints and a is_readable($tmp_name) check inside your loop, just to more finely try to pin-point the source of the problem.

answered Dec 14, 2009 at 20:36

DrYak

1,1461 gold badge10 silver badges16 bronze badges

Comments

antpaw · Accepted Answer · 2009-12-14 20:26:46Z

-1

i guess onsubmit="return Validare();" is returning false

why are you using this rand function anyway, try time() it's better i think

answered Dec 14, 2009 at 20:26

antpaw

16.1k11 gold badges63 silver badges94 bronze badges

1 Comment

Brad Over a year ago

Do not use time(). He is using the rand() function to try and get a pseudo random number. If you use time(), you will not get this as multiple files can be uploaded in a given second.

helloandre · Accepted Answer · 2009-12-14 20:27:34Z

-1

you want $_FILES['file'][$i]['size']

answered Dec 14, 2009 at 20:27

helloandre

10.8k9 gold badges50 silver badges64 bronze badges

1 Comment

Powerlord Over a year ago

Sorry, but that's wrong: php.net/manual/en/features.file-upload.multiple.php

Collectives™ on Stack Overflow

Php upload file

7 Answers 7

1 Comment

3 Comments

1 Comment

3 Comments

Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

1 Comment

3 Comments

1 Comment

3 Comments

Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related