avoid function closure in javascript

Question

I want to link a callback to each input (type text) with class 'liveVariable':

$(".liveParameter").keyup(function(){
    var callBackString= 'skp:change-'+$(this).attr('id')+'@'+$(this).attr('value');
    window.location = callBackString;               
});

However, this gives me a strange error. The value passes is the initial value of the input field (every time the event is fired).

I don't understand why this doesn't work. I dont think I have a closure, the local variable callBackString is created in the called function. So it should be created every time over?

How can I solve this in an elegant manner? (I would not like to create a call for each input field, cause I have many live parameters..)

Also, just for the sake of my OCD, change $(this).attr("id") to this.id — Reinstate Monica Cellio
– Reinstate Monica Cellio, Commented Sep 27, 2013 at 8:49
@ChrisKempen The benefits of not constructing a huge jQuery object just to get the id of the element which can be accessed directly with this.id? :) — Andreas
– Andreas, Commented Sep 27, 2013 at 8:52

Paul Rad · Accepted Answer · 2013-09-27 08:47:30Z

1

Change in your code

$(this).attr('value'); // get the initial value

$(this).val(); // get the current and updated value

http://jsfiddle.net/FjgLB/

answered Sep 27, 2013 at 8:47

Paul Rad

4,8821 gold badge26 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chris Kempen · Accepted Answer · 2013-09-27 09:00:10Z

1

Try changing:

var callBackString= 'skp:change-'+$(this).attr('id')+'@'+$(this).attr('value');

...to:

var callBackString= 'skp:change-'+$(this).attr('id')+'@'+$(this).val();

More detail on the .val() function can be found on the jQuery docs website here.

Edit:

For the sake of elegance, performance, and comment contribution, the following solution would ultimately be the best:

$(".liveParameter").keyup(function(){
    var input = $(this);
    var callBackString = 'skp:change-' + input.attr('id') + '@' + input.val();
    window.location = callBackString;
});

edited Sep 27, 2013 at 9:00

answered Sep 27, 2013 at 8:46

Chris Kempen

9,6715 gold badges43 silver badges52 bronze badges

Collectives™ on Stack Overflow

avoid function closure in javascript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related