Simple JS function using text inputs and parseInt, returns NaN

Question

Can anyone help me figure out why I keep getting a NaN result?

   function showShares() {
 var tot = document.getElementById('total').innerHTML;
 var pri = document.getElementById('price').innerHTML;
 var per = document.getElementById('percent').innerHTML;

 var shar = parseInt(tot, 10) * parseFloat(per) / parseFloat(pri);
   document.getElementById("shares").innerHTML=Math.round(shar);

}

<td><text id="price"><%= StockQuote::Stock.quote(current_user.fund1).last %></text></td>

 <td><text id="shares"></text></td>
 <td><text id="percent">.50</text></td>

<p class="alignright1"><input type="text" id="total" size="8"></input>
<br><a href onclick="showShares()">here</a>

The stock quote is returning an integer in the cell ie. 25.38. it returns the same NaN if I remove the embedded ruby and place a simple integer ie. 50. The same is true if I replace the input with a number.

Thank You

Debug, e.g. alert( parseInt(tot, 10) + ' | '+ parseInt(per, 10) +' | '+parseInt(pri, 10) ) — Oriol
– Oriol, Commented Sep 28, 2013 at 0:02
document.getElementById('total').innerHTML isn't the way to get a value from an input element. Try document.getElementById('total').value — sissonb
– sissonb, Commented Sep 28, 2013 at 0:14
Thank You Very Much! I was using .value earlier. The debug code was very Helpful! — TlfT
– TlfT, Commented Sep 28, 2013 at 0:18

Paul Rad · Accepted Answer · 2013-09-28 00:02:51Z

1

Try this :

function showShares() {
 var tot = document.getElementById('total').innerHTML;
 var pri = document.getElementById('price').innerHTML;
 var per = document.getElementById('percent').innerHTML;

 var shar = parseInt(tot, 10) * parseFloat(per, 10) / parseInt(pri, 10);
   document.getElementById("shares").innerHTML=Math.round(shar);

}

The percent value is a float (digit with comma) and must be interpreted by the JS engine like a float ;)

answered Sep 28, 2013 at 0:02

Paul Rad

4,8821 gold badge26 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

TlfT Over a year ago

Thank You, I had just realized this too. Combined with the debug help above I get NaN | .5 | 23

sissonb · Accepted Answer · 2013-09-28 00:16:32Z

0

You are trying to get a value from an input element with this code, document.getElementById('total').innerHTML

That's not the way to get the value from the input. You should use this code,

document.getElementById('total').value

answered Sep 28, 2013 at 0:16

sissonb

3,7904 gold badges31 silver badges56 bronze badges

Collectives™ on Stack Overflow

Simple JS function using text inputs and parseInt, returns NaN

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related