Getting issues in object oriented perl

Question

I am new to OO perl. I am trying to write one simple program but getting the error.

Created a package Employee.pm as

package Employee;

sub new {
    my $class = shift;
    my $self = {};
    bless $self, $class;
    return $self;
}

sub get_names {
    my $self = @_;
    print " getting the names \n";
    return $self;
}

sub set_names {
    my ($self, $last_name) = @_;
    $self->{last_name} = $last_name;
    return $self->{$last_name};
}
1;

And created a .pl file as

use strict;
use warnings;

use Employee;

my $obj = new Employee("name" => "nitesh", "last_name" => "Goyal");

my $val = $obj->get_names();

print %$val;

my $setName = $obj->set_names("kumar");

print "$setName \n";

I am getting error as

"Can't use string ("1") as a HASH ref while "strict refs" in use at class1.txt line   10."

One another query : Like in "sub get_names" we are declaring $self = @_ , and in the calling script we are passing as $obj->get_names(). Why no arguments need to give while calling when we have done $self = @_ in the sub. — Sumit
– Sumit, Commented Sep 28, 2013 at 10:40
Please do not correct your code in the question. If you remove your errors, our answers will look pretty strange. If you have new questions about your code, ask a new question. This one is asked and answered now. — TLP
– TLP, Commented Sep 28, 2013 at 11:07
It is my mistake. Really sorry. Next time it will not happen — Sumit
– Sumit, Commented Sep 28, 2013 at 11:09

TLP · Accepted Answer · 2013-09-28 10:50:43Z

2

The error

"Can't use string ("1") as a HASH ref ..

Comes from this part:

sub get_names {
    my $self = @_;

When an array is put in scalar context, it returns its size. Since you call the sub with

$obj->get_names();

Only one argument is passed, which is the object, so @_ contains 1 argument, and its size is 1, therefore in the sub get_names, the variable $self is set to 1. Hence the error. What you probably should do is

my $self = shift;

But then, that will not do anything, because you never stored the names in your constructor. As mpapec said, you should do

my $self = { @_ };

in the constructor sub new.

Also, in get_names, you simply return the object, which is not very useful. You should perhaps return $self->{name} and $self->{last_name}.

answered Sep 28, 2013 at 10:50

TLP

68.2k10 gold badges97 silver badges156 bronze badges

Sign up to request clarification or add additional context in comments.

11 Comments

Sumit Over a year ago

thanks. But what does this mean "But then, that will not do anything, because you never stored the names in your constructor. As mpapec said, you should do"

TLP Over a year ago

When you called new you never stored the arguments anywhere. You only stored an empty hash ref, {}.

TLP Over a year ago

That is because you set $self->{last_name}, but you return $self->{$last_name}.

TLP Over a year ago

@Nitesh If you did $self = @_ then you have not understood my answer, and I encourage you to read that part again.

TLP Over a year ago

@Nitesh You do not need to supply arguments to get_names because you are getting the names from the object, and the object is stored in $obj.

|

Collectives™ on Stack Overflow

Getting issues in object oriented perl

1 Answer 1

11 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

11 Comments

Your Answer

Sign up or log in

Post as a guest

Related