PHP string comparasion

Question

I have a variable and its type is string. var_dump() shows:

var_dump() output is below:

string(14)

//this is my code..

$game_cat = "Some text"; // some text mean actually it is one of below Category 1,2,3,4 ...

if ( $game_cat === "Category 1" ) {
        $cid = 1;
}

if ( $game_cat === "Category 2" ) {
        $cid = 2;
}

if ( $game_cat === "Category 3" ) {
        $cid = 0;
}

else{
       $cid = 999999;
}

For example when I change $game_cat to Category 1 like $game_cat = "Category 1"; $cid must 1 but output is 999999.

Why?

Try using ==, if that works, then the strings might be the same value, but not EXACTLY the same. Notice your string has 14 characters while "Category 1" has 10, 12 including the double quotes — Sterling Archer
– Sterling Archer, Commented Sep 30, 2013 at 15:27
For string comparison he should have no difference between == and ===. Double check that your capitalization is the same, and that you aren't appending extra spaces with trim(). — Nathaniel Ford
– Nathaniel Ford, Commented Sep 30, 2013 at 15:29
print_r the variable and let's see if it's actually what you say it is — Sterling Archer
– Sterling Archer, Commented Sep 30, 2013 at 15:31
$game_cat giving its value dynamically but when I do var_dump type and length is the same. — hakki
– hakki, Commented Sep 30, 2013 at 15:31

Naftali · Accepted Answer · 2013-09-30 15:29:12Z

3

Use elseif

if ( $game_cat === "Category 1" ) {
        $cid = 1;
}

elseif ( $game_cat === "Category 2" ) {
        $cid = 2;
}

elseif ( $game_cat === "Category 3" ) {
        $cid = 0;
}

else{
       $cid = 999999;
}

What your current code does:

if ( $game_cat === "Category 1" ) {
        $cid = 1; //cid is 1
}

if ( $game_cat === "Category 2" ) {
        $cid = 2; //skipped
}

if ( $game_cat === "Category 3" ) {
        $cid = 0; //skipped
}

else{
       $cid = 999999; //cid == 999999
}

answered Sep 30, 2013 at 15:29

Naftali

147k41 gold badges247 silver badges304 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Reactgular Over a year ago

@hakiko he is correct, you are hitting the old if this and for everything else bug.

Jesz · Accepted Answer · 2013-09-30 15:30:12Z

1

You're using multiple if-statements, while this should just be one (else-if). So, at first your variable will be 1, but because the last if-statement overwrites it, you'll get the wrong answer.

Do something like:

if ( $game_cat === "Category 1" ) {
        $cid = 1;
}
elseif ( $game_cat === "Category 2" ) {
        $cid = 2;
}
elseif ( $game_cat === "Category 3" ) {
        $cid = 0;
}
else{
       $cid = 999999;
}

For more information about elseif, check http://php.net/manual/en/control-structures.elseif.php :)

answered Sep 30, 2013 at 15:30

Jesz

111 bronze badge

Comments

Mr. B. · Accepted Answer · 2013-09-30 15:54:48Z

1

Edit: Working demo:

http://phpfiddle.org/main/code/g02-bjj

Try this:

$game_cat = "Category 2";

if ( $game_cat === "Category 1" ) {
        $cid = 1;
}

elseif ( $game_cat === "Category 2" ) {
    $cid = 2;
}

elseif ( $game_cat === "Category 3" ) {
    $cid = 0;
}

else {
   $cid = 999999;
}

Hope it helps!

edited Sep 30, 2013 at 15:54

answered Sep 30, 2013 at 15:29

Mr. B.

8,82516 gold badges76 silver badges121 bronze badges

1 Comment

Mr. B. Over a year ago

@hakiko take a look at the example, it's working: phpfiddle.org/main/code/g02-bjj

w00d · Accepted Answer · 2013-09-30 15:29:41Z

0

Because of the last else. Since It's "Category 1" $cid will be set as 1 at the first if condition, however it will be reset because it's not "Category 3".

You should use "elseif" instead of concatenating many "if" in this case.

answered Sep 30, 2013 at 15:29

w00d

5,62614 gold badges56 silver badges86 bronze badges

Collectives™ on Stack Overflow

PHP string comparasion

4 Answers 4

1 Comment

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related