Shell Script with If, Select and Case

Question

Can anyone advise how to edit this script to perform the following:

If folder exists - "then are you sure you want to uninstall?" If yes - perform file copying, if not then stop script. Else - can't find folder, stop script.

if [ -e "/tmp/installpackage" ]
then
    echo "Are you sure you want to uninstall?"
    select yn in "Yes" "No"; do
        case $yn in
            Yes ) 
                echo "Beginning uninstall...";
                cp file1.txt original/path/location;
                break;;
            No ) 
                echo "Stopping uninstall.";
                exit 1;;
        esac
    done
else
    echo "Can't find the folder, package not isntalled."
    exit 1
fi

Did you try with a "read" command? It's easier and more readable. — opalenzuela
– opalenzuela, Commented Oct 1, 2013 at 14:57
What's the problem with your script? It looks like it does what you want it to. — dogbane
– dogbane, Commented Oct 1, 2013 at 14:59
I've tried a few methods at this stage. My script goes through a continuous entry loop and won't actually do anything that I've coded for. — Dustin Cook
– Dustin Cook, Commented Oct 1, 2013 at 15:00
This is a modified script, that I found online, to which I've inserted it inside an if statement. — Dustin Cook
– Dustin Cook, Commented Oct 1, 2013 at 15:06

hek2mgl · Accepted Answer · 2013-10-01 16:19:52Z

3

Your code works as expected. But you have to enter 1 or 2 and not yes or no.

However I would change the first line to:

if [ -d "/tmp/installpackage" ]

-d tests whether the file exists and is a directory

edited Oct 1, 2013 at 16:19

answered Oct 1, 2013 at 15:06

hek2mgl

159k31 gold badges263 silver badges279 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

tripleee Over a year ago

Actually the expression after case does not require quoting.

hek2mgl Over a year ago

@tripleee Yeah this makes sense. (As long as the value list just contains just "yes" and "no"). However, quoting vars is a good practice. Better do it one more than one less - if this won't break anything

CS Pei · Accepted Answer · 2013-10-01 15:10:24Z

0

I think after the line esac you want a exit otherwise you have a infinite loop to ask you for answers

answered Oct 1, 2013 at 15:10

CS Pei

11.1k1 gold badge29 silver badges46 bronze badges

Comments

krouis · Accepted Answer · 2013-10-01 15:13:57Z

0

try

if [ -d "/tmp/installpackage" ]
then
    echo "Are you sure you want to uninstall?"
    select yn in "Yes" "No"; do
        case $REPLY in
            Yes ) 
                echo "Beginning uninstall...";
                cp file1.txt original/path/location;
                break;;
            No ) 
                echo "Stopping uninstall.";
                exit 1;;
            *)
                echo "Incorrect choice";
                break;;
        esac
    done
else
    echo "Can't find the folder, package not installed."
    exit 1
fi

answered Oct 1, 2013 at 15:13

krouis

1294 bronze badges

Comments

Cole Tierney · Accepted Answer · 2013-10-01 15:32:40Z

0

I would try testing for bail out conditions first then fall through to the uninstall code:

[ ! -d '/tmp/installpackage' ] && \
echo "Can't find the folder, package not isntalled." && exit 1

echo -n 'Are you sure you want to uninstall? [y|n] '
read answer
[[ ! "$answer" = [Yy] ]] && echo 'Stopping uninstall.' && exit 1

echo 'Beginning uninstall...'
cp file1.txt original/path/location

answered Oct 1, 2013 at 15:32

Cole Tierney

10.4k2 gold badges31 silver badges38 bronze badges

Collectives™ on Stack Overflow

Shell Script with If, Select and Case

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related