PHP script giving false results

Question

The script:

<?php
    $dir = 'http://www.example.com/';
    $page = '
        <script src="folder/script.js" type="text/javascript"></script>
        <script type="text/javascript" src="folder/script.js"></script>';
    $last = $data = $property = 0;
    //search for all script tags
    while (($last = stripos($page, '<script', $property))!==false) {
        //find src property
        $property = stripos($page, 'scr', $last);
        if ($property===false && $property > $last+50) continue;
        //find the start of the address
        $data = stripos($page, '"', $property) + 1;
        if ($data===false && $data > $prop+5) continue;
        if (substr($page, $data, 4) !== 'http') {
            $page = substr($page, 0, $data) . $dir . substr($page, $data);
        }
    }
    echo $page;
?>

output:

<script src="http://www.example.com/folder/script.js" type="text/javascript"></script>
<script type="http://www.example.com/text/javascript" src="folder/script.js"></script>

Why is it inserting $dir after the first ("), not after the (") of src attribute?

You have a typo in there: scr instead of src in $property = stripos($page, 'scr', $last); .. Just sayin' — Smuuf
– Smuuf, Commented Oct 2, 2013 at 18:53
@OIS I will, thanks. Like Ansel Adams was a photographic genius/master, thought of himself as a "student" of the "art" ;-) cheers — Funk Forty Niner
– Funk Forty Niner, Commented Oct 2, 2013 at 18:58
if ($property===false && $property > $last+50) continue; <- This will never be true. It can be reduced to: if (0 > 50) — OIS
– OIS, Commented Oct 2, 2013 at 19:03

OIS · Accepted Answer · 2013-10-02 19:15:24Z

1

Using regex:

$dir = 'http://www.example.com/';
$page = '
    <script src="folder/script.js" type="text/javascript"></script>
    <script type="text/javascript" src="folder/script.js"></script>';
$regex = '#(<script .*src=")#';
$replace = '\1\2' . $dir;
$page = preg_replace($regex, $replace, $page);
echo htmlspecialchars($page);

Result:

<script src="http://www.example.com/folder/script.js" type="text/javascript"></script>
<script type="text/javascript" src="http://www.example.com/folder/script.js"></script>

answered Oct 2, 2013 at 19:15

OIS

10.1k3 gold badges35 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP script giving false results

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related