Using if statement in PHP

Question

I would like to do these actions step by step:

first DB update
copy file
unlink file
second DB update

It is working, but I don't know if my code is correct/valid:

$update1 = $DB->query("UPDATE...");

  if ($update1)
  {
    if (copy("..."))
    {
      if (unlink("..."))
      {
        $update2 = $DB->query("UPDATE ..."); 
      }         
    }
  }

Is it possible to use if statement this way?

I found that it is usually used with PHP operators and PHP MySQL select, for example:

$select = $DB->row("SELECT number...");
  if ($select->number == 2) {
  ...
  }

if is used pretty much whenever there is conditional branching that needs to occur. It doesn't matter where the value comes from (and yes, SQL is one popular data source). In any case, see the documentation for whichever method to see what the results mean. You may also want to ensure that update2 "succeeded" and/or use a transaction or optimistic concurrency. — user2246674
– user2246674, Commented Oct 4, 2013 at 0:46
If you have working code and you want to improve it, consider asking on codereview.stackexchange.com — kojiro
– kojiro, Commented Oct 4, 2013 at 0:54

scrowler · Accepted Answer · 2013-10-04 01:25:08Z

1

Sure, your ifs work fine. What would look and flow better would be using a function like this:

function processThings() {
    // make sure anything you use in here is either passed in or global

    if(!$update1)
        return false;

    if(!$copy)
        return false;

    if(!$unlink)
        return false;

    if(!$update2)
        return false;

    // you made it!
    return true;
}

make sure you call $DB as a global variable, plus pass in whatever strings you need etc etc

answered Oct 4, 2013 at 1:25

scrowler

24.4k10 gold badges67 silver badges99 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Using if statement in PHP

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related