Netty java getting data from ByteBuf

Question

How to get a byte array from ByteBuf efficiently in the code below? I need to get the array and then serialize it.

package testingNetty;
import io.netty.buffer.ByteBuf;
import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.ChannelInboundHandlerAdapter;

public class ServerHandler extends  ChannelInboundHandlerAdapter {
     @Override
        public void channelRead(ChannelHandlerContext ctx, Object msg) {
         System.out.println("Message receive");
         ByteBuf buff = (ByteBuf) msg;
             // There is I need get bytes from buff and make serialization
         byte[] bytes = BuffConvertor.GetBytes(buff);
        }

        @Override
        public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) { 
            // Close the connection when an exception is raised.
            cause.printStackTrace();
            ctx.close();
        }

}

Can you please post the complete code. Also mention the which version of netty you are using? — ajay_t
– ajay_t, Commented Oct 10, 2013 at 13:12
So what's problem is? What do you mean by bytes massive in the above context? — ajay_t
– ajay_t, Commented Oct 10, 2013 at 13:35
Bytes massive means a byte[] wich contains seriziable object — NiceTheo
– NiceTheo, Commented Oct 10, 2013 at 14:12

trustin · Accepted Answer · 2015-10-11 10:40:07Z

91

ByteBuf buf = ...
byte[] bytes = new byte[buf.readableBytes()];
buf.readBytes(bytes);

If you don't want the readerIndex to change:

ByteBuf buf = ...
byte[] bytes = new byte[buf.readableBytes()];
int readerIndex = buf.readerIndex();
buf.getBytes(readerIndex, bytes);

If you want to minimize the memory copy, you can use the backing array of the ByteBuf, if it's available:

ByteBuf buf = ...
byte[] bytes;
int offset;
int length = buf.readableBytes();

if (buf.hasArray()) {
    bytes = buf.array();
    offset = buf.arrayOffset();
} else {
    bytes = new byte[length];
    buf.getBytes(buf.readerIndex(), bytes);
    offset = 0;
}

Please note that you can't simply use buf.array(), because:

Not all ByteBufs have backing array. Some are off-heap buffers (i.e. direct memory)
Even if a ByteBuf has a backing array (i.e. buf.hasArray() returns true), the following isn't necessarily true because the buffer might be a slice of other buffer or a pooled buffer:
- buf.array()[0] == buf.getByte(0)
- buf.array().length == buf.capacity()

edited Oct 11, 2015 at 10:40

answered Oct 11, 2013 at 2:29

trustin

12.4k6 gold badges44 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

chappjc Over a year ago

@user2132106 would like to know if he can do byte[] ar= buf.array() (if I understand the post correctly).

trustin Over a year ago

Updated the answer for him.

Fireburn Over a year ago

@trustin what's the purpose of the offset here?

zipper Over a year ago

I tested with real data: the second way (minimize the memory copy) is wrong. Java platform: Oracle 1.8; netty version: 4.1.58.Final.

trustin Over a year ago

@Fireburn offset tells at which position in the array the first byte starts.

|

Lion · Accepted Answer · 2022-11-16 12:59:43Z

6

Another option is ByteBufUtil.getBytes(ByteBuf buf, int start, int length, boolean copy)

See ByteBufUtil

edited Nov 16, 2022 at 12:59

answered Sep 23, 2022 at 6:50

Lion

1,03512 silver badges24 bronze badges

2 Comments

Tuomas Kiviaho Over a year ago

There is indeed an option to share the array instead of copying it (if possible)

Lion Over a year ago

Thanks @TuomasKiviaho . I updated my answer per your comment.

Collectives™ on Stack Overflow

Netty java getting data from ByteBuf

2 Answers 2

8 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

8 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related