non-binary tree using recursion is not creating entire tree

Question

I have a simple function to recursively build a tree of strings. The function is given a string "***" and the tree that results should look like this:

                                        ***
                                 /       |       \
                              X**       *X*       **X
                             / \        / \        / \
                          XX*  X*X    XX* *XX    X*X  *XX 
                          /     \     /     \     /     \
                         XXX   XXX   XXX   XXX   XXX    XXX

The problem is that my function is only creating the farthest left side of the tree (X**, XX*, XXX)

Here is the function:

//Takes in the string "***"
void buildTree(string tree){
 if (tree == "XXX") return;
 else{
   string newTree;
   for (int i=0; i<tree.size(); i++){
     if(tree[i] == '*'){
       newTree = tree;
       newTree[i] = 'X';
       cout << newTree << endl;
       return buildTree(newTree);
     }
   }
 }
}

I indented the code correctly. Maybe you are now able to spot the error more easily — Oswald
– Oswald, Commented Oct 11, 2013 at 0:20

X.J · Accepted Answer · 2013-10-11 00:20:38Z

1

Remove 'return' from "return buildTree(newTree);" and you should be good to go.

answered Oct 11, 2013 at 0:20

X.J

6623 silver badges6 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

non-binary tree using recursion is not creating entire tree

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related