Changing variable values on href with PHP

Question

I'm implementing a PHP function to translate my website based on HTTP_ACCEPT_LANGUAGE, but also by user choice:

<?php 
if (!isset($language)) {
$language = explode(',',$_SERVER['HTTP_ACCEPT_LANGUAGE']);
$language = strtolower(substr(chop($language[0]),0,2));
}

include("functions/content_".$language.".php"); 
?>

User choice comes when the user clicks a link in the navbar, like this:

<ul>
<li><a href="portfolio.php?language=es">Español</a></li>
<li><a href="portfolio.php?language=en">Enshlish</a></li>
<li><a href="portfolio.php?language=fr">Français</a></li>
</ul>

Problem is I can't get to change the value of $language with the hrefs, it always self-defines as "es" (my browser is set to Spanish).

try $language = $_GET['language']; (register_globals is probably off) — Marty McVry
– Marty McVry, Commented Oct 13, 2013 at 16:46

The Alpha · Accepted Answer · 2013-10-13 16:59:11Z

1

You may try this

$language = isset($_GET['language']) ? $_GET['language'] : false;
if(!$language) {
    $language = explode(',',$_SERVER['HTTP_ACCEPT_LANGUAGE']);
    $language = strtolower(substr(chop($language[0]),0,2));
}

Also, you can use a function (a helper function), like

function setlanguage()
{
    $language = isset($_GET['language']) ? $_GET['language'] : false;
    if(!$language) {
        $language = explode(',',$_SERVER['HTTP_ACCEPT_LANGUAGE']);
        $language = strtolower(substr(chop($language[0]),0,2));
    }
    return $language;
}

Use it like

$language = setlanguage();
include("functions/content_".$language.".php");

edited Oct 13, 2013 at 16:59

answered Oct 13, 2013 at 16:48

The Alpha

147k30 gold badges294 silver badges313 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Joe T Over a year ago

i like to use if(isset($_GET['language'])) so the page doesn't generate an apache error every time it loads without the $_GET var set

The Alpha Over a year ago

@JoeT, It's better now, IMO.

Joe T · Accepted Answer · 2013-10-13 16:46:52Z

1

are you getting the value of $language before checking whether it's set? With register_globals off you need to get it from the $_GET variable to get it from the URL:
if(isset($_GET['language'])){ $language = $_GET['language']; }

answered Oct 13, 2013 at 16:46

Joe T

2,3601 gold badge19 silver badges34 bronze badges

Collectives™ on Stack Overflow

Changing variable values on href with PHP

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related