Passing URL variable via $_GET to Javascript

Question

I have a PHP page with the following URL:

http://xyz.com/dev/gallery.php?k=1&s=35

The following Javascript file is included on the PHP page:

<script type="text/javascript" src="js/some-js-file.php"></script>

The some-js-file.php needs to be filled dynamically using PHP:

jQuery(function($){$.supersized({

<?php 
$sql = "SELECT * FROM tbl WHERE id=".$_GET['s']." ORDER BY pos ASC"; 
$result = mysql_query($sql); 
    while($rs = mysql_fetch_row($result)){
    ...do some output here...
    }
?>

});
});

For some reason, $_GET['s'] is empty. Any ideas why? Thanks in advance for any help!

Danger: You are using an obsolete database API and should use a modern replacement. You are also vulnerable to SQL injection attacks that a modern API would make it easier to defend yourself from. — Quentin
– Quentin, Commented Oct 15, 2013 at 13:49

Community · Accepted Answer · 2017-05-23 12:05:14Z

1

Pass the parameter to the JavaScript file as well:

<script src="js/some-js-file.php?s=<?php print $_GET['s']; ?>"></script>

N.B.: Please pay attention to Quentin's comments and make sure that you use the approach securely.

edited May 23, 2017 at 12:05

CommunityBot

11 silver badge

answered Oct 15, 2013 at 13:49

VisioN

146k35 gold badges287 silver badges291 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Quentin Over a year ago

Danger: This is vulnerable to XSS attacks. Never insert external data into HTML without sanitising it! Add htmlspecialchars to fix it.

Collectives™ on Stack Overflow

Passing URL variable via $_GET to Javascript

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related