For loop to go through different arrays / Java

Question

I am searching for short version for this kind of code:

        if (database_1[0].equalsIgnoreCase(data)) {

            preparedStatement = connect
                    .prepareStatement("update SLIP.CONTACTS set`database_1`=? where user='"
                            + user + "'");

            preparedStatement.setString(1, vnos );
            preparedStatement.executeUpdate();

        }       else if (database_2[0].equalsIgnoreCase(data)) {

            preparedStatement = connect
                    .prepareStatement("update SLIP.CONTACTS set`database_2`=? where user='"
                            + user + "'");

            preparedStatement.setString(1, vnos );
            preparedStatement.executeUpdate();

        }

So database_1[0] is a String array. And I need his first element to check if equals a string data. Is there a shortcut (for loop) to change database_1[0] to database_2[0] and then to database_3[0] and so on..thx in advance for help

James Cronen · Accepted Answer · 2013-10-17 17:06:10Z

1

Multi-dimensional array?

for (int j = 0; j < numberOfDatabases; j++) {
    if (database[j][0].equalsIgnoreCase(data)) {
        preparedStatement = connect
                           .prepareStatement("update SLIP.CONTACTS set `database_" 
                                                 + j + "`=? where user=?");

        preparedStatement.setString(1, vnos);
        preparedStatement.setString(2, user);
        preparedStatement.executeUpdate();

        break;
    }
}

Or better yet, use an appropriate data structure to hold your database references.

List<String[]> databases = new ArrayList<String[]>();

// Populate databases.

for (int j = 0; j < databases.size(); j++) {
    if (database.get(j)[0].equalsIgnoreCase(data)) {
        preparedStatement = connect
                           .prepareStatement("update SLIP.CONTACTS set `database_" 
                                                 + j + "`=? where user=?");

        preparedStatement.setString(1, vnos);
        preparedStatement.setString(2, user);
        preparedStatement.executeUpdate();

        break;
    }
}

Notice that here I index from 0 to size - 1.

To javaL's point, you can also replace user in your PreparedStatement as noted above.

edited Oct 17, 2013 at 17:06

answered Oct 17, 2013 at 17:00

James Cronen

5,7732 gold badges36 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user2380133 Over a year ago

why where user='"+ user + "'" why not where user=?

James Cronen Over a year ago

Sorry, I was solving the problem of array indexing. I didn't look at his PreparedStatement.

James Cronen Over a year ago

Fixed the PreparedStatement.

Jay Nebhwani · Accepted Answer · 2013-10-17 17:05:00Z

0

You could use a nested array.

String [][] databases = new String[numberOfDatabases][itemsInEachDatabase];

for (int i = 0; i < itemsInEachDatabase; i++) {
  databases[0][i] = database_1[i];
}
// repeat this for loop for other databases

for (int i = 0; i < numberOfDatabases; i++) {
  if (databases[i][0].equalsIgnoreCase(data)) {
    // your code here
  }
}

answered Oct 17, 2013 at 17:05

Jay Nebhwani

9767 silver badges11 bronze badges

Collectives™ on Stack Overflow

For loop to go through different arrays / Java

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related