PHP in_array() not working

Question

I have a security token that is created when a page loads and writes that token to a file. Then I confirm that the token passed in the form matches one of the tokens in the file.

This first section is located in the FORM.PHP file, and I can confirm that the token is being written to the file.

//Create Token
$token = md5(time());

//Save token to file
$fp = fopen('/PATH/tokens.txt', 'a') or die ("Unable to open to Token file");
fwrite($fp, "$token\n") or die ("Unable to write to Token file");
fclose($fp);

This section of code is located in the PROCESS.PHP file. I have printed out the contents of the $tokens array and I can manually confirm that the same token is in there.

$tokens = file('/PATH/tokens.txt') or die("Unable to read file");

$token = $_POST['token'];

if (in_array($token, $tokens)){
   error_log("Found Token");
} else {
   error_log("Token Not Found");
}

I can't figure out why the in_array($token, $tokens) function is not returning TRUE.

Wrikken · Accepted Answer · 2013-10-17 23:29:27Z

2

Use file('/path/file.ext',FILE_IGNORE_NEW_LINES);, otherwise every entry has the newline characters from the file appended.

answered Oct 17, 2013 at 23:29

Wrikken

70.8k8 gold badges99 silver badges136 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

bjori · Accepted Answer · 2013-10-17 23:29:44Z

2

file() keeps the newlines character by default, which means you are matching a md5() to md5()\n.

To strip the newline character out, you need to pass FILE_IGNORE_NEW_LINES as a second argument to file()

answered Oct 17, 2013 at 23:29

bjori

2,1142 gold badges15 silver badges15 bronze badges

Comments

Loopo · Accepted Answer · 2013-10-17 23:33:26Z

0

the file function will return an array with the newlines attached

answered Oct 17, 2013 at 23:33

Loopo

2,1952 gold badges31 silver badges48 bronze badges

Collectives™ on Stack Overflow

PHP in_array() not working

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related