Set HTML select menu using PHP

Question

I need to set the items in a PHP drop down menu based on a number of conditions.

Here's my code:

<select class="span3" id="filter-source">
    <option selected="selected">Select source</option> 
    <?php
    if (($_SESSION['val1']==="value")||($_SESSION['id']==5)) {
        echo '<option';
        if ($val2 == "Something"){
            echo 'selected="selected"';
        }
        echo'Something</option>';
    }
    ?>
</select>

So what I'm doing is displaying the option in the select dropdown only if one the two conditions for the session variables is true. Once 'Something' is selected then $val2 is set as something and on refreshing the page it is displayed as the selected option in the select drop down menu.

This does not result in an server error but the option does not show up at all even if the conditions for the session variables are satisfied.

What am I doing wrong and what is the correct way to do this?

Sometimes a quick look at the HTML source is quicker than a post on SO... — Laurent S.
– Laurent S., Commented Oct 18, 2013 at 12:13

Luke · Accepted Answer · 2013-10-18 12:17:09Z

6

Looks to me like you're not closing your <option> tag, i've added the closing > before 'Something':

<select class="span3" id="filter-source">
            <option selected="selected">Select source</option> 
            <?php
            if(($_SESSION['val1']==="value")||($_SESSION['id']==5))
            {
                echo '<option'; 

                if ($val2 == "Something") {
                    echo 'selected="selected"';
                }

                echo '>Something</option>';
            }
            ?>
</select>

I'd also like to offer up the following piece of cleaner code:

<?php
if(($_SESSION['val1'] === "value") || ($_SESSION['id'] == 5))
{
    echo '<option' . (($val2 == "Something") ? 'selected="selected"' : '') . '>Something</option>';
}
?>

edited Oct 18, 2013 at 12:17

answered Oct 18, 2013 at 12:11

Luke

23.8k31 gold badges121 silver badges202 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user2891084 · Accepted Answer · 2013-10-18 12:24:15Z

2

<select class="span3" id="filter-source" autocomplete="off">
<option selected="selected">Select source</option>
<?php if( $_SESSION['val1']==="value" && $_SESSION['id']==5) { ?>
<option <?php if($_SESSION['val1'] === "value" && $_SESSION['id'] ==5) {echo 'selected="selected"';} ?>> Something</option>
 <?php }?>

answered Oct 18, 2013 at 12:24

user2891084

1114 bronze badges

Collectives™ on Stack Overflow

Set HTML select menu using PHP

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related