Explode to array in PHP

Question

I'm dealing with this program,Here I'm trying to separate the string email,by ',',and then I'm storing in the array,then appending with 'city' in foreach..

$email='aa,bb,cc,dd';
$a=explode(',',$email);
//echo $a[2];
$result="";
foreach($a as $v)
{
     $result .= " city = '$v' ";
     echo $result;
}

I'm getting the result as

city = 'aa' city = 'aa' city = 'bb' city = 'aa' city = 'bb' city = 'cc' city = 'aa' city = 'bb' city = 'cc' city = 'dd'

but I want it to be,,

city = 'aa' city = 'bb' city = 'cc' city = 'dd'

Is my code wrong?..please guide me..

Don't put the echo in the loop. That's why it outputs the progressively growing list. — mario
– mario, Commented Oct 19, 2013 at 3:57

Hanky Panky · Accepted Answer · 2013-10-19 03:56:57Z

2

Move the echo out of the loop since you are building the whole string in the loop, this will echo the string every time.

$result="";
foreach($a as $v)
{
     $result .= " city = '$v' ";

}

     echo $result;  // move it here

answered Oct 19, 2013 at 3:56

Hanky Panky

46.9k9 gold badges76 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Funk Forty Niner Over a year ago

Maybe I should put in the same answer too. (joking)

Funk Forty Niner Over a year ago

@user2810964 You know what to do.

Funk Forty Niner Over a year ago

@Hanky웃Panky SO can be so funny sometimes hehehe (+1) ;-)

Sobin Augustine · Accepted Answer · 2013-10-19 04:03:09Z

0

You are getting the result as per your code, you echo the result in each loop execution.

So for getting the final values inside $result, echo it outside the loop.

foreach($a as $v)
{
    $result .= " city = '$v' ";
}
echo $result;

answered Oct 19, 2013 at 4:03

Sobin Augustine

3,7752 gold badges28 silver badges43 bronze badges

Comments

Ryan decosta · Accepted Answer · 2013-10-19 04:06:10Z

0

Remove the string concatenation in the result

 $email='aa,bb,cc,dd';
$a=explode(',',$email);
//echo $a[2];
$result="";
foreach($a as $v)
{
     $result = " city = '$v' ";//changed $result .= " city = '$v' "; to $result = " city = '$v' ";
     echo $result;
}

answered Oct 19, 2013 at 4:06

Ryan decosta

4551 gold badge4 silver badges10 bronze badges

Comments

Kevin G Flynn · Accepted Answer · 2013-10-19 04:36:27Z

0

You are echo $rresult in foreach so your string or variable is repeat. Please try below code :

$email='aa,bb,cc,dd';
$a=explode(',',$email);

$result="";
foreach($a as $v)
{
    $result .= " city = '$v' ";     
}
echo $result;

answered Oct 19, 2013 at 4:36

Kevin G Flynn

2314 silver badges14 bronze badges

Comments

Sumit Bijvani · Accepted Answer · 2013-10-19 05:04:04Z

0

Remove string concate..

$email='aa,bb,cc,dd';
$a=explode(',',$email);
//echo $a[2];
$result="";
foreach($a as $v)
{
     $result = " city = '$v' ";  // remove string concate..
     echo $result;
}

Another way is echo outside the foreach loop...

$email='aa,bb,cc,dd';
$a=explode(',',$email);
//echo $a[2];
$result="";
foreach($a as $v)
{
     $result .= " city = '$v' "; 
}

echo $result; // echo outside the foreach loop

Output

city = 'aa' city = 'bb' city = 'cc' city = 'dd'

answered Oct 19, 2013 at 5:04

Sumit Bijvani

8,17518 gold badges52 silver badges83 bronze badges

Collectives™ on Stack Overflow

Explode to array in PHP

5 Answers 5

3 Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

3 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related