Error in my Java code

Question

I've got a problem with my Java program. There is an error in my code on line 16 (t = T[i];) which implies an error on line 12. It says :

Syntax error on token "=",VariableInitializer expected after this token.

Could I have some help ?

public class Ngrams {

    public static boolean estPrefixe(String t, String s) {
        int Longs = s.length();
        if (t.substring(0, Longs) == s) {
            return true;
        } else {
            return false;
        }
    }

    public static int nbOccurences(String[] T, String s) {
        int compteur = 0;
        String t = null;
        for (int i = 0; i < T.length; i++) {
            t = T[i];
            if (estPrefixe(t, s)) {
                compteur++;
            }
            return compteur;
        }
    }

The code compiles fine for me. BTW estPrefix appears to be the same as String.startsWith — Peter Lawrey
– Peter Lawrey, Commented Oct 20, 2013 at 15:56
There was a } missing. I may have accedently fixed the code when trying to fix the formatting. — Peter Lawrey
– Peter Lawrey, Commented Oct 20, 2013 at 15:58
@PeterLawrey: Yeah, you did accidentally fix the code. Give me a moment and I'll fix the formatting. — Makoto
– Makoto, Commented Oct 20, 2013 at 16:02

Makoto · Accepted Answer · 2013-10-20 16:03:45Z

2

Notwithstanding the fact that you're comparing Strings with == instead of .equals(), and that a right bracket seems to have gone AWOL, at the end of your program, you're "missing" a return statement in nbOccurences. Even though you have one in the for-loop, if you never enter the loop, you don't return anything.

Move your return statement down one line, outside of the loop instead.

public static int nbOccurences(String[] T, String s) {
    int compteur = 0;
    String t = null;
    for (int i = 0; i < T.length; i++) {
        t = T[i];
        if (estPrefixe(t, s)) {
            compteur++;
        }
    }
    return compteur;
}

edited Oct 20, 2013 at 16:03

answered Oct 20, 2013 at 15:56

Makoto

107k29 gold badges199 silver badges236 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

micha · Accepted Answer · 2013-10-20 15:57:01Z

1

The method nbOccurences does not always return an int value. If T is null or empty (length = 0) no value is returned. So you should add another return statement after the for loop.

As others mentioned already you should use equals to compare strings. This however, is not producing a syntax error.

answered Oct 20, 2013 at 15:57

micha

49.8k16 gold badges75 silver badges80 bronze badges

Comments

Bohemian · Accepted Answer · 2013-10-20 16:01:35Z

1

Well there's a serious bug in this line:

if (t.substring(0, Longs) == s) {

This test will always be false, because == compares object references, not values. Change it to:

if (t.substring(0, Longs).equals(s)) {

But the whole method is pointless. Change it to:

public static boolean estPrefixe(String t, String s) {
    return t.startsWith(s);
}

Or just delete the method altogether because it adds no value whatsoever.

answered Oct 20, 2013 at 16:01

Bohemian♦

427k103 gold badges603 silver badges750 bronze badges

1 Comment

Prizoff Over a year ago

"This test will always be false" - this is not always true. If t and s are the same object than result of this equation will be true. In the same time, yes, topic starter should always use .equals instead of =.

Collectives™ on Stack Overflow

Error in my Java code

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related