Rails ActiveRecord update_all array of ids

Question

I have an ActiveRecord Model called Animal. Animal has id and client_id. In my app have an array called @selectedanimals that contains the id's of the animals I want to update such as: @selectedanimals: ["6", "14", "5"]. I have the value of a new client_id for these animals like @newclient.id and I want to update all of these Animal records with the new client_id. What I have now is:

Animal.update_all({:client_id => @transferclient.id}, {:id => @selecteanimals})

I know this is not 100% correct because it is having a problem with :id. I get an error like this: Called id for nil, which would mistakenly be 8 -- if you really wanted the id of nil, use object_id

Forgive my ignorance but this is my first time using update_all and I don't see any examples where you pass it an array of the ids of the records you want to update so any help would be appreciated much.

EDIT: Apparently the @transferclient.id was not properly defined. That was my problem. Thanks all.

Are you trying to update with single client_id or multiple client_id's ? — Siva
– Siva, Commented Oct 22, 2013 at 6:25
single client_id and multiple animals - but, I found that the real issue with the code was that @transferclient.id was not properly defined. — Drew Harris
– Drew Harris, Commented Oct 23, 2013 at 13:55
It might work but the code I have listed in my question worked just fine once I properly defined @transferclient.id. — Drew Harris
– Drew Harris, Commented Oct 23, 2013 at 14:53

Community · Accepted Answer · 2017-05-23 12:09:03Z

2

I am new to Ruby so I don't know if there's been some recent change in the API but Danpe's answer as well as the initial suggestion that actually worked according to the asker, didn't work for me. They both raised a syntax error.

The solution that worked for me and is actually proposed in the API documentation is this:

Animal.where(:id => @selectedanimals).update_all(:client_id => @transferclient.id)

edited May 23, 2017 at 12:09

CommunityBot

11 silver badge

answered Feb 6, 2017 at 11:09

Angelos Makrygiorgos

1,4522 gold badges9 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Danpe · Accepted Answer · 2013-10-22 04:59:32Z

0

You need to check if id is inside that array:

Animal.update_all({:client_id => @transferclient.id}, {"id IN (?)" , @selecteanimals})

answered Oct 22, 2013 at 4:59

Danpe

19.1k21 gold badges98 silver badges131 bronze badges

1 Comment

Drew Harris Over a year ago

Thanks for your answer but the code I had in my question worked once I properly defined @transferclient.id. That was my problem.

Collectives™ on Stack Overflow

Rails ActiveRecord update_all array of ids

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related