Rails routes redirect for query string

Question

I have a problem, recently the name of a controller changed.

I changed the routes file to accept calls using the old controller name, for people with bookmarks referencing the old name:

get '/old/about', to: redirect('/new/about')
get '/old/report/:client', to: redirect('/new/report/%{client}')
get '/old/:sub_path', to: redirect('/new/%{sub_path}')

that works fine. But for calls with query string it blocks it to /report/200. for example:

/old/report/200?c_id=257&end=2013-10-19&num_results=294540&start=2013-10-13

it cuts the url to:

old/report/200

and shows me an error because of the lack of parameters. Do you know what can I do? (I thought the :sub_path line in the routes would help but not) :(

Possible duplicate: stackoverflow.com/questions/14039181/… — Matt Grande
– Matt Grande, Commented Oct 23, 2013 at 18:11
I think you can be right, let me check it out, Thanks a lot! — Alejandra
– Alejandra, Commented Oct 23, 2013 at 18:12

Eliot Sykes · Accepted Answer · 2018-02-26 11:08:56Z

21

Modify redirect to use the path: option to preserve the querystring:

- get '/old/about', to: redirect('/new/about')
+ get '/old/about', to: redirect(path: '/new/about')

This is demonstrated in the API docs for redirect, see http://api.rubyonrails.org/classes/ActionDispatch/Routing/Redirection.html#method-i-redirect

edited Feb 26, 2018 at 11:08

answered Feb 7, 2017 at 10:29

Eliot Sykes

10.2k6 gold badges55 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Alejandra · Accepted Answer · 2013-10-23 19:15:16Z

12

The question mention by Matt helped me to figure out my answer (thanks a lot!). It was a slightly different for my specific case. Im leaving the answer that worked for me for future reference.

match "/old/report/:client" => redirect{ |params, request| "/new/report/#{params[:client]}?#{request.query_string}" }

answered Oct 23, 2013 at 19:15

Alejandra

7263 gold badges9 silver badges25 bronze badges

1 Comment

Vadim Eremeev Over a year ago

I would modify it a bit to check if request.query_string present as current solution always will add '?' to the bottom.

ben · Accepted Answer · 2016-08-04 15:40:54Z

3

Building on Alejandra's answer, more verbose but without the ? if there's no query string:

get "/old/report/:client", to: redirect{ |params, request| ["/new/report/#{params[:client]}", request.query_string.presence].compact.join('?') }

So /old/report/:client?with=param will become /new/report/:client?with=param, and /old/report/:client will become /new/report/:client.

answered Aug 4, 2016 at 15:40

ben

1,47212 silver badges18 bronze badges

Comments

Michael Trojanek · Accepted Answer · 2019-03-01 10:00:13Z

The existing answers work perfectly, but are not quite suitable for keeping things DRY — there is a lot of duplicate code once you need to redirect more than one route.

In this case, a custom redirector is an elegant approach:

class QueryRedirector
  def call(params, request)
    uri = URI.parse(request.original_url)
    if uri.query
      "#{@destination}?#{uri.query}"
    else
      @destination
    end
  end

  def initialize(destination)
    @destination = destination
  end
end

Now you can provide the redirect method with a new instance of this class:

get "/old/report/:client", to: redirect(QueryRedirector.new("/new/report/#{params[:client]}"))

I have a written an article with a more detailed explanation.

Collectives™ on Stack Overflow

Rails routes redirect for query string

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related