Trouble calling javascript function from php

Question

I am trying to do the following:

<html>
<script type="text/javascript" src="jquery.js"></script>

<a id="random">before</a>   
<script>
function test(a)
  {
      document.getElementById('random').innerHTML="after with variable passed in";
  }
function test2()
  {
      document.getElementById('random').innerHTML="after without variable passed in";
  }
</script>
<?php $sample = "hi"; ?>

<button onClick="test(<?php echo $sample;?>)">withVariable</button>

<button onClick="test2()">withoutVariable</button>
</html>

If I click the "withoutVariable" button, the function test2() gets called perfectly because no variables are passed in to it. However, if I click the "withVariable" button the function test(a) is never being called for some reason. Any ideas what I'm doing wrong here?

Arun P Johny · Accepted Answer · 2013-10-24 05:06:33Z

3

Since $sample is a string literal you need to enclose it with ''

<button onClick="test('<?php echo $sample;?>')">withVariable</button>

answered Oct 24, 2013 at 5:06

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

SKLAK Over a year ago

Wow, I wish I had asked earlier.. Such a small mistake

DreadPirateShawn · Accepted Answer · 2013-10-24 05:28:09Z

0

If you're passing a string variable, then you need to add quotes around the value, like so:

<button onClick="test('<?php echo $sample;?>')">withVariable</button>

edited Oct 24, 2013 at 5:28

DreadPirateShawn

8,4304 gold badges51 silver badges71 bronze badges

answered Oct 24, 2013 at 5:07

StaleMartyr

7785 silver badges18 bronze badges

Collectives™ on Stack Overflow

Trouble calling javascript function from php

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related