JavaScript embedding <script> tags in document.write not working

Question

I'm not sure what is wrong with my code, but when I try and add actorWin.document.write('<script type=\"text/javascript\"><\/script>') everything gets screwed up. Without this line, the code works fine.

<!DOCTYPE html>
<meta charset="utf-8">
<title>create a window</title>

<script type='text/javascript'>
  function Movie(title, actor) {
    this.title = title;
    this.actor= actor;    
  }
</script>
</head>
<body>
<script type='text/javascript'>

  var documentary = new Movie('http://www.imdb.com/title/tt0358456/?ref_=fn_al_tt_2','http://en.wikipedia.org/wiki/Joaquin_Phoenix');
  var movieWin = new Object();
  var actorWin = new Object();  

  newWin=window.open('','Win','width=300,height=200,top=100,left=600');

   newWin.document.write(
   "<script type='text/javascript'>" +
        "function PopUpWindowMovie(url) {" +
             "movieWin=window.open(url,'','height=600,width=800,left=400,top=100,scrollbars,status,resizable');" +
             "movieWin.focus();}" + 
        "function PopUpWindowActor(){" +
             "actorWin=window.open('','','height=600,width=800,left=400,top=100,scrollbars,status,resizable');" +
             "actorWin.focus(); " +
             "actorWin.document.write('Joaquin Phoenix is a great actor and a long time vegan.<br />');" +
             "actorWin.document.write('<script type=\"text/javascript\">" +
             "function test() {" +
                    "alert(\"here\");" +
             "} <\/script>');" +
        "}" +
    "<\/script>"); 
   newWin.document.write("This is a MUST SEE movie: <h1>Earthlings (2005)</h1>");
   newWin.document.write("<a href=\"javascript:PopUpWindowMovie('"+documentary.title+"')\">Go to see the movie info</a><br />");
   newWin.document.write("<a href=\"javascript:PopUpWindowActor()\">Go to see the lead actor</a>");
</script>

</body>
</html>

Mulitple document.write statements aren't a good idea, create a single text string and do one write. Far better to put all the script in external files, then load HTML into the popups rather than writing it. — RobG
– RobG, Commented Oct 25, 2013 at 0:06

KiT O · Accepted Answer · 2013-10-25 00:13:24Z

9

Just change closing script tag inside other script tag to fool browser.

change :

actorWin.document.write('<script type=\"text/javascript\"><\/script>')

to :

actorWin.document.write('<script type=\"text/javascript\"><\/scr'+'ipt>')

Edit :

Full code :

 newWin.document.write(
   "<script type='text/javascript'>" +
        "function PopUpWindowMovie(url) {" +
             "movieWin=window.open(url,'','height=600,width=800,left=400,top=100,scrollbars,status,resizable');" +
             "movieWin.focus();}" + 
        "function PopUpWindowActor(){" +
             "actorWin=window.open('','','height=600,width=800,left=400,top=100,scrollbars,status,resizable');" +
             "actorWin.focus(); " +
             "actorWin.document.write('Joaquin Phoenix is a great actor and a long time vegan.<br />');" +
             "actorWin.document.write('<script type=\"text/javascript\">" +
             "function test() {" +
                    "alert(\"here\");" +
             "} <\/scr'+'ipt>');" + // <-- I've edited this line
        "}" +
    "<\/script>"); 
   newWin.document.write("This is a MUST SEE movie: <h1>Earthlings (2005)</h1>");
   newWin.document.write("<a href=\"javascript:PopUpWindowMovie('"+documentary.title+"')\">Go to see the movie info</a><br />");
   newWin.document.write("<a href=\"javascript:PopUpWindowActor()\">Go to see the lead actor</a>");

edited Oct 25, 2013 at 0:13

answered Oct 24, 2013 at 23:41

KiT O

8677 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

RobG Over a year ago

That does nothing at all, it's the </ that signifies the closing tag, so <\/ (per the OP) is the correct treatment to disguise it.

KiT O Over a year ago

I've tested that and it works, the real problem here is using closing script tag inside another script tag.

RobG Over a year ago

You have a test case where '<\/script>' fails but '<\/scr' + 'ipt>' doesn't? I'd like to see that.

KiT O Over a year ago

In my knowledge of javascript "<\/script>" has value of <\script>. That's the difference!

Tom Stickel Over a year ago

'<\/scr' + 'ipt>' does nothing not needed only '<\/script>' is needed

Trevor · Accepted Answer · 2013-10-24 23:48:19Z

3

If your embedding javascript in an HTML page the HTML parser when it finds your first script tag will immediately try to find the closing tag. Since your closing script tag is in your document.write you'll find yourself in a pickle.

You can easily just escape the closing forward slash on the tag with a backslash:

document.write("<script>alert('foo')</script>')

To:

document.write("<script>alert('foo')<\/script>')

answered Oct 24, 2013 at 23:48

Trevor

6307 silver badges11 bronze badges

Comments

The Alpha · Accepted Answer · 2013-10-25 00:03:26Z

1

but when I try and add actorWin.document.write('</script>') everything gets screwed up

Not sure what's the problem but it may help you

Writing to a document that has already loaded without calling document.open() will automatically perform a document.open call.

About document.open call

If a document exists in the target, this method clears it.

Well, whatever your problem is, you may use this approach

var newWin = window.open('','Win','width=300,height=200,top=100,left=600');

// Then add scripts
var script1 = document.createElement('script');
script1.innerHTML = "function someFunc(){  alert('Hello'); }";
newWin.document.getElementsByTagName('head')[0].appendChild(script1);

var script2 = document.createElement('script');
script2.src = "http://code.jquery.com/jquery-git2.js";
newWin.document.getElementsByTagName('head')[0].appendChild(script2);

This should work. An Example here.

edited Oct 25, 2013 at 0:03

answered Oct 24, 2013 at 23:50

The Alpha

147k30 gold badges294 silver badges313 bronze badges

1 Comment

here Over a year ago

this will break a script you are adding if the added script tries to use document.write

Collectives™ on Stack Overflow

JavaScript embedding <script> tags in document.write not working

3 Answers 3

5 Comments

Comments

Well, whatever your problem is, you may use this approach

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

Comments

Well, whatever your problem is, you may use this approach

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related