Replace function of JavaScript don't work

Question

I have next code in javascript:

csvReport.name = "My New Report";
$scope.filename = csvReport.name.replace(" ", "_");

But I get $scope.filename = My_New Report. Not all spaces replacing.

What is it?

all answers below are correct, yet none of the authors care to upvote the other correct ones... that's a bit of a disappointment :( — Zathrus Writer
– Zathrus Writer, Commented Oct 25, 2013 at 12:24

Karl-André Gagnon · Accepted Answer · 2013-10-25 12:22:45Z

5

.replace will always replace the first occurence except if you use regular expression like that :

csvReport.name.replace(/ /g, "_");

answered Oct 25, 2013 at 12:22

Karl-André Gagnon

33.9k5 gold badges53 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Satpal · Accepted Answer · 2013-10-25 12:22:13Z

5

You can use replace with a regular expression :

"My New Report".replace(/ /g,'_')

Demo

answered Oct 25, 2013 at 12:22

Satpal

134k13 gold badges168 silver badges171 bronze badges

Comments

Zathrus Writer · Accepted Answer · 2013-10-25 12:22:16Z

4

You can use regular expression with a global switch (g) to actually replace all instances, like this:

csvReport.name = "My New Report";
$scope.filename = csvReport.name.replace(/ /g, "_");

answered Oct 25, 2013 at 12:22

Zathrus Writer

4,3315 gold badges30 silver badges53 bronze badges

Comments

maketest · Accepted Answer · 2013-10-25 12:34:36Z

2

Function replace only replace first appearance of first argument. You can use regular expression to replace in whole string.

Try this:

if (!String.replaceAll) {
    String.prototype.replaceAll = function(replace, value) {
        var regexpStr = replace.replace(/[-[\]{}()*+?.,\\^$|#\s]/g, "\\$&")
        return this.replace(new RegExp(regExpStr, 'g'), value);
    };
}

This way you have additional function that works on whole string.

edited Oct 25, 2013 at 12:34

answered Oct 25, 2013 at 12:22

maketest

3011 silver badge8 bronze badges

2 Comments

Karl-André Gagnon Over a year ago

This work for the space, but it is dangerous if he want to replace character like . since . mean every character in regExp. However you can escape in your function with a regexp. Or escape it when calling the function : .replaceAll('\\.', '_')

maketest Over a year ago

@Karl-AndréGagnon I have modified my answer with adding escaping replace string for regexp special characters.

Collectives™ on Stack Overflow

Replace function of JavaScript don't work

4 Answers 4

Comments

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related