Nested For Loop (C++) Not Working Properly

Question

I am working on some programming homework and I am trying to use a for-loop in order to facilitate the process of the coding. Here is the loop:

#ifndef DIVSALES_H
#define DIVSALES_H

class DivSales
{
    public:
        DivSales(){ quarterSales[4] = {0}; };
        double getTotalSales() { return totalSales;}
        static void setTotalSales(double);
        static void addTotalSales(double);
        double getQuarterSales(int numQuarter) {return quarterSales[numQuarter];}
        void setQuarterSales(int numQuarter, double numAmount) { quarterSales[numQuarter] = numAmount;}
    private:
        static double totalSales;
        double quarterSales[];
};

double DivSales::totalSales = 0;
void DivSales::setTotalSales(double totalAmount) {totalSales = totalAmount; }
void DivSales::addTotalSales(double addAmount) {totalSales += addAmount; }
#endif // DIVSALES_H

#include <iostream>
#include "DivSales.h"

using namespace std;

int main()
{
    const int NUMDIVS = 6;
    const int NUMQUARTERS = 4;
    double amount = 0;

    DivSales divs[NUMDIVS];

    for(int division = 0; division < NUMDIVS; division++)
    {
        cout << "Division " << (division + 1) << endl;

        for(int quarter = 0; quarter < NUMQUARTERS; quarter++)
        {
            cout << "Quarter " << (quarter + 1) << ": ";
            cin >> amount;

            divs[division].setQuarterSales(quarter, amount);
            DivSales::addTotalSales(amount);
        }
    }


    return 0;
}

Example of the output:

Division 1
Quarter 1: 500
Quarter 2: 500
Quarter 3: 500
Quarter 2: 500
Quarter 3: 500
Quarter 2: 500
Quarter 3: 500
Quarter 2: 500
Quarter 3: 500
Quarter 2:

What I am trying to do is make it so that when I have input the numbers for the 4 quarters of a division, that it will move onto the next division. However, after 4 inputs it is not incrementing the division variable of the for-loop instead it continues asking for more inputs. What is going on?

I can't see anything wrong with the code you pasted, so my guess is something's happening inside the setQuarterSales and setTotalSales functions. Have you tried stepping through the code with the debugger? — benjymous
– benjymous, Commented Oct 25, 2013 at 15:29
I added the cout and also updated the question with the new code as well as example output with that code. — Mourneris
– Mourneris, Commented Oct 25, 2013 at 15:48

memo1288 · Accepted Answer · 2013-10-25 15:57:51Z

2

I have found what's causing that problem, it is in the file DivSales.h:

Change this line:

double quarterSales[];

For this line:

double quarterSales[4];

The problem was that you were not allocating memory for an array of 4 elements. To initialize it, change your constructor to this:

DivSales():quarterSales({0}){ };

You should also move the following line to DivSales.cpp, because otherwise I was getting a multiple definition error:

double DivSales::totalSales = 0;

edited Oct 25, 2013 at 15:57

answered Oct 25, 2013 at 15:44

memo1288

7381 gold badge6 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Sarien Over a year ago

I couldn't even get it to compile without this change.

Mourneris Over a year ago

Would you mind including the code as to how to dynamically allocate the memory for the array? My professor can't explain this stuff to save her own life.

Scott Mermelstein Over a year ago

@user2920558 No need for the array to be dynamic. memo1288 gave details on how to statically allocate and initialize the array properly.

Sarien Over a year ago

@memo1288 Does DivSales():quarterSales({0}){ }; initialize the entire array to 0? Which C++ version is that? MS compiler doesn't like it.

memo1288 Over a year ago

@Sarien Yes, it does. I tested it with MinGW 4.6.2 (dafault settings). Haven't tested it with the MS compiler, though.

|

Sarien · Accepted Answer · 2013-10-25 15:35:38Z

0

Here:

divs[division].setTotalSales(amount);

you probably want:

divs[division].addTotalSales(amount);

But that is not what is causing your problem. Which I cannot reproduce.

answered Oct 25, 2013 at 15:35

Sarien

7,0426 gold badges39 silver badges57 bronze badges

1 Comment

Mourneris Over a year ago

Thank you for the suggestion. It had completely flown over my head but I fixed it now.

Collectives™ on Stack Overflow

Nested For Loop (C++) Not Working Properly

2 Answers 2

7 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related