php mysql_query insert into not working

Question

<form method="post" action="updatescreen(2).php">
Name of company:<br />
<input type="text" name="artid" id="artid" size="50" /><br /><br />
<input type="submit" name="Insert" id="Insert" value="Insert" /><br /><br />

<?php
if(isset($_POST['Insert'])){
    $id = $_POST['artid'];

    mysql_query("INSERT INTO test (id) VALUES ('$id', )");
}

?></form>

The connection to the database is included so not mentioned here. The connection is working fine, that's not the problem.

The problem is: the php code doesn't work. The php code doesn't insert the data into my database. What's wrong?

are you getting any errors?

Suresh Kamrushi
– Suresh Kamrushi

2013-11-06 13:32:09 +00:00
Commented Nov 6, 2013 at 13:32 — Suresh Kamrushi
– Suresh Kamrushi, Commented Nov 6, 2013 at 13:32

user399666 · Accepted Answer · 2013-11-06 13:32:23Z

3

You had a , after '$id':

mysql_query("INSERT INTO test (id) VALUES ('$id')");

Your code is also open to SQL injection. You should be using something like PDO instead of the mysql_* functions, which are deprecated. With PDO, you can guard against SQL injections by using prepared statements.

answered Nov 6, 2013 at 13:32

user399666

20k7 gold badges49 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Praveen · Accepted Answer · 2013-11-06 13:32:39Z

3

Change

mysql_query("INSERT INTO test (id) VALUES ('$id', )");

to

mysql_query("INSERT INTO test (id) VALUES ('$id')");

answered Nov 6, 2013 at 13:32

Praveen

2,4193 gold badges26 silver badges31 bronze badges

Comments

Shai · Accepted Answer · 2013-11-06 13:38:27Z

2

You have one comma too many.

mysql_query("INSERT INTO test (id) VALUES ('$id')");

In future, try printing the error, which will help you debug the problem yourself:

mysql_query("INSERT INTO test (id) VALUES ('$id')") or die(mysql_error());

And please use PDO or mysqli instead of the mysql_ functions, which are insecure and deprecated.

edited Nov 6, 2013 at 13:38

Shai

7,3573 gold badges21 silver badges22 bronze badges

answered Nov 6, 2013 at 13:34

TiMESPLiNTER

5,9193 gold badges31 silver badges68 bronze badges

Comments

demenvil · Accepted Answer · 2013-11-06 13:35:31Z

0

Try

<?php if(isset($_POST['Insert'])){
    $id = $_POST['artid'];

    mysql_query("INSERT INTO test (id) VALUES ('".$id."')")or die(mysql_error());
}?>


  <form method="post" action="updatescreen(2).php">
Name of company:<br />
<input type="text" name="artid" id="artid" size="50" /><br /><br />
<input type="submit" name="Insert" id="Insert" value="Insert" /><br /><br />

And => think about the safety!

answered Nov 6, 2013 at 13:35

demenvil

1,1291 gold badge12 silver badges25 bronze badges

Comments

CreatoR · Accepted Answer · 2013-11-06 13:39:01Z

0

Errors:

mysql_query("INSERT INTO test (id) VALUES ('$id', )");
                                             ^---not secure, potencial sql injection
                                                ^----not need ","

Use this code for more security (most of all better pdo or mysqli):

if(isset($_POST['Insert'])){
   $id = mysql_real_escape_string($_POST['artid']);
   mysql_query("INSERT INTO test (id) VALUES ('$id')");

}

answered Nov 6, 2013 at 13:39

CreatoR

1,65210 silver badges14 bronze badges

Collectives™ on Stack Overflow

php mysql_query insert into not working

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related