Creating array of arrays in loop in Perl

Question

I'm trying to create an array-of-arrays with some data in a for loop. The regex command in the code below helps me to gather the scalars that I will place in it. As far as I know, that is correct, but when I try to output the @output array to a CSV file I receive a "Can't use string () as an ARRAY ref while "strict refs" in use." error. Is this because of the way I am creating the array or the way I'm trying to write it into a file?

foreach my $row(@input){
    my @cmd = qx("command");
    foreach my $line(@cmd){
        if($line =~ /regex/){
            push(@output, ($sp_name, $sp_port, $sp_type, $sp_uid)); 
        }
    }
}

The code below is what I am using to create my output file::

my $csv = Text::CSV->new()
    or die "Cannot use Text::CSV ($!)";
my $file = "output.csv";
open my $fh, '>', $file
    or die "Cannot open $file ($!)";
$csv->eol("\n");
foreach my $row (@output)
{
    $csv->print($fh, \@{$row})
        or die "Failed to write $file ($!)";
}
close $fh
    or die "Failed to close $file ($!)";

After you apply the fixed mentioned below, change \@{$row} back to the simpler $row. — ikegami
– ikegami, Commented Nov 7, 2013 at 21:46

Greg Bacon · Accepted Answer · 2013-11-07 22:30:34Z

5

This is pushing four scalars onto @output:

push(@output, ($sp_name, $sp_port, $sp_type, $sp_uid));

The parentheses do nothing but uselessly control precedence. Use square brackets:

push @output, [ $sp_name, $sp_port, $sp_type, $sp_uid ];

The square brackets create an array and return a reference to it.

edited Nov 7, 2013 at 22:30

Greg Bacon

141k34 gold badges196 silver badges253 bronze badges

answered Nov 7, 2013 at 21:41

David W.

107k40 gold badges224 silver badges349 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Creating array of arrays in loop in Perl

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related