"using" keyword in header implementation in C++

Question

I was reading Accelerated c++ chapter 4 where they teach about dividing a c++ program in different files. Here, they write that we should not use the "using _::" construct in header files because whoever is including the header might want to use a different implementation. But while implementing the methods in the header file, the use of "using" is fine. Can you please clarify this? While linking the implementation object file, won't the program eventually use the "using::" construct? Here is the code:

//median.h file
#ifndef GUARD_median_h
#define GUARD_median_h
#include <algorithm>
#include <vector>

double median(std::vector<double>); // <<<<<<<< no "using std::vector"
#endif

But in median.cpp:

#include <vector>
#include <stdexcept>

using std::vector; // <<<<< "using" construct used
using std::domain_error; // <<<<< "using" construct used

double median(vector<double> vec){
    if(vec.size() == 0) throw domain_error("median for an empty vector not defined");
    //....... rest of the implementation
}

To clarify a bit more:

Here is my client calling the above header:

#include "median.h"
using my_vector_impl::vector;
//..some function...
    std::vector v1;
    double med = median(v1);

Am I right in saying that we prevent "using std::vector" in header so that we can use line 2 in above code?

uk4321 · Accepted Answer · 2013-11-12 22:14:56Z

19

using is simply a compile-time shortcut to shorten names. It has no effect at runtime. Also, it only affects the source code which is at or below its own scope, so if you use it in the implementation file, no other files can see it, but if you use it in the header, all the files that include the header will have the using in them and their namespace will be polluted.

Edit:

To answer your updated question, your example isn't quite why you should avoid using in headers. This is why:

// Header:

using std::vector;

// Client:

#include <Header>

class vector { ... };

void f() {
    vector v; // Ambiguous because of something out of my control
}

This is the situation you want to avoid. You don't want to tell the people who use your libraries what names they can use, which you are doing when you do using.

edited Nov 12, 2013 at 22:14

answered Nov 12, 2013 at 21:25

uk4321

1,0888 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

kmad Over a year ago

hi uk, could you answer the last part?

mah · Accepted Answer · 2013-11-12 21:24:35Z

4

This simply means you can put using … in your C++ source. You could also reasonably put it in a private header that you include but no external user would include. You just don't want to mess with your client's environment and putting using in a header that they are required to include could do that.

While linking the implementation object file, won't the program eventually use the "using::" construct? The using keyword is just a convenience to the compiler, not something that changes what gets linked. It only affects the sources that use it.

answered Nov 12, 2013 at 21:24

mah

40.1k9 gold badges79 silver badges94 bronze badges

Comments

Joel · Accepted Answer · 2013-11-12 21:24:44Z

The "using" declaration is only a compile time construct, saving you from having to type std:: (or another namespace) over and over again. In your own .cpp implementation file, it's fine to use a using declaration because you have control over that file. If you include it in a .h (header) file, every file that includes that header would also be including your using declaration, including the ones you don't have control over, and may never have even heard of.

A classic example would be an implementation file that's using tr1::shared_ptr, vs std::shared_ptr which only came along later. If your header file includes std::shared_ptr, then their code will no longer compile, and it's difficult for them to know why.

Incidentally, this is also why macros are now considered evil.

Collectives™ on Stack Overflow

"using" keyword in header implementation in C++

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related