Getting error of Input String Format

Question

i use a repeater instead of grid view .In button i done with code but when i debug it shows me error....and i am trying approving documents but error occur

ok now i posted the whole code,,

   protected void Button1_Click(object sender, EventArgs e)
    {
     string connStr = ConfigurationManager.ConnectionStrings["mydms"].ConnectionString;
          SqlConnection mySQLconnection = new SqlConnection(connStr);
          if (mySQLconnection.State == ConnectionState.Closed)
          {
              mySQLconnection.Open();

              for (int i = 0; i < Repeater2.Items.Count; i++)
              {
                  DropDownList DropDownListcontrol =
              ((DropDownList)Repeater2.Items[i].FindControl("DropDownList4"));
                  Label DocId = ((Label)Repeater2.Items[i].FindControl("DocId"));
                 SqlCommand cmd = new SqlCommand("approveddd", mySQLconnection);
                  cmd.CommandType = CommandType.StoredProcedure;
                  cmd.Parameters.Add("@DocID", SqlDbType.Int).Value =
                 Convert.ToInt32((DocId.Text));

                  cmd.Parameters.Add("@ApproveID", SqlDbType.Int).Value = 
            Convert.ToInt32(DropDownListcontrol.SelectedValue);
                  cmd.Parameters.Add("@ApproveBy", SqlDbType.VarChar, 50).Value = 
               (Session["Login2"]);

                  cmd.ExecuteNonQuery();
                  //UPDATE APPPROVEID IN DOCUMENTINFO TABLE
                  DMSLIB.Doc myDoc = new DMSLIB.Doc();
                  myDoc.MarkDocAs(Convert.ToInt16(DocId.Text), 
                Convert.ToInt32(DropDownListcontrol.SelectedValue));

              }

          }
          else
          {
              apfi.Text = "Error";
          }
          if (mySQLconnection.State == ConnectionState.Open)
          {
              mySQLconnection.Close();
          }
                }

error in this line

                      cmd.Parameters.Add("@DocID", SqlDbType.Int).Value =
             Convert.ToInt32((DocId.Text));

any idea?

ERROR: INPUT STRING WAS NOT IN CORRECT FORMAT

Does DocId.Textcontains a number? An empty value, for instance, will generate an error. — Rubens Farias
– Rubens Farias, Commented Nov 14, 2013 at 11:54
in html like this..... <td> <asp:Label Id="DocId" runat="server"></asp:Label> <%#DataBinder.Eval(Container.DataItem, "DocID")%> </td> — user2931015
– user2931015, Commented Nov 14, 2013 at 11:54

Vaibhav Parmar · Accepted Answer · 2013-11-14 12:02:52Z

1

That error comes because if DocId.Text is empty, you are trying to convert an empty string into an integer, and this is what gives you the "Input string was not in a correct format." exception.

You need to first of all detect if the DocID is an empty string, and assign -1 (say) to your cmd instance.

you have to first do:

DocId.Text= (DocId.Text == "") ? DBNull.Value : Convert.ToInt32(DocId.Text);

then assign it to cmd object

cmd.Parameters.Add("@DocID", SqlDbType.Int).Value =Convert.ToInt32((DocId.Text));

answered Nov 14, 2013 at 12:02

Vaibhav Parmar

6634 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

The Hungry Dictator · Accepted Answer · 2013-11-14 11:59:12Z

1

<td> <asp:Label Id="DocId" text='<%#DataBinder.Eval(Container.DataItem, "DocID")%>' runat="server"></asp:Label>  </td>

bind like this in your aspx page....

answered Nov 14, 2013 at 11:59

The Hungry Dictator

3,4845 gold badges41 silver badges56 bronze badges

Collectives™ on Stack Overflow

Getting error of Input String Format

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related