PHP dropdown menu populating from mysql not working

Question

I've spent hours reading and trying to figure out why this is not working but the drop down menu does not populate. I think it's something simple but I just cannot see it. Anyone?

dbconn.php

<?php

define('DB_NAME' , 'artprints');
define('DB_USER' , 'root');
define('DB_PASS' , '');
define('DB_HOST' , 'localhost');

func.php

<?php

include_once 'dbconn.php';

function connect(){
    $connection = mysqli_connect(DB_HOST, DB_USER, DB_PASS) or die ('Could not connect to the database' . mysl_error());
    mysqli_select_db($connection, DB_NAME);
}

function close(){
    mysql_close();
}

function query(){
    $myData = mysql_query("SELECT * FROM artists");
    while ($record = mysql_fetch_array($myData)){
    echo '<option value="' . $record['artistID'] . '">' . $record['artistID'] . '</option>';
    }
}

test.php

<?php
 include_once 'func.php';
 connect();
 ?>

 <html>
 <head>
 <title>Drop down testing</title>
 </head>
 <body>
 <select name='artist'>
 <?php query() ?>
 </select>
 <?php close() ?>
 </body>
 </html>

Please post error messages

Ayaz
– Ayaz

2013-11-14 13:23:41 +00:00
Commented Nov 14, 2013 at 13:23 — Ayaz
– Ayaz, Commented Nov 14, 2013 at 13:23
var_dump($myData); please

Brewal
– Brewal

2013-11-14 13:24:20 +00:00
Commented Nov 14, 2013 at 13:24 — Brewal
– Brewal, Commented Nov 14, 2013 at 13:24

davidkonrad · Accepted Answer · 2013-11-14 13:24:55Z

8

You are mixing mysqli_* and mysql_*

mysqli_connect and mysqli_select_db

against

mysql_query and mysql_fetch_array

answered Nov 14, 2013 at 13:24

davidkonrad

85.7k17 gold badges211 silver badges273 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Brewal Over a year ago

That's a reason why we would rather use PDO

q0re Over a year ago

and he forgot ; after function call (query() and close()).

oldmanpete Over a year ago

davidkonrad, you're my hero, thanks! Brewal, I'm investigating PDO now, I am reasonably new to PHP and didn't even know this existed. q0re, you're right although it works without them? As a matter of better coding practice I assume they are required and will use them in future. Thanks all!

Veerendra · Accepted Answer · 2013-11-14 13:34:22Z

1

Copy and paste this in your function.php

include_once ('dbconn.php');

function connect()
{
    $connection = mysqli_connect(DB_HOST, DB_USER, DB_PASS) or die ('Could not connect to the database' . mysl_error());
    mysqli_select_db($connection, DB_NAME);
}

function close(){
    mysqli_close();
}

function query(){
    $myData = mysqli_query("SELECT * FROM artists");
    while ($record = mysql_fetch_array($myData)){
    echo '<option value="' . $record['artistID'] . '">' . $record['artistID'] . '</option>';
    }
}

answered Nov 14, 2013 at 13:34

Veerendra

2,6202 gold badges25 silver badges39 bronze badges

Collectives™ on Stack Overflow

PHP dropdown menu populating from mysql not working

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related