avoiding a duplicated output in PHP

Question

I have a problem on my script it duplicates the output from the .html file. here is my code below.

php:

<?php
$html = file_exists('try.html') ? file_get_contents('try.html') : die('unable to open the file');

$data['test1'] = 'WRITE 1';

$data['test2'] = 'WRITE 2';

foreach ($data as $search => $value)
{
    if(preg_match_all('#(<([a-zA-Z]+)[^>]*id=")(.*'.$search.')("[^>]*>)([^<]*?)(</\\2>)#ism', $html, $matches, PREG_SET_ORDER))
    {
        foreach($matches as $match) 
        {
            $xhtml = str_replace($match[5],$value,$html);
            echo $xhtml;
        }
    }
}
?>

html:

<html>
<head>
<title>TRY</title>
</head>
<body>
<div id="test1">A</div>
<div id="test2">B</div>
</body>
</html>

OUTPUT:

WRITE 1
B

A
WRITE 2

it duplicates the output.

DESIRED OUTPUT:

WRITE 1
WRITE 2

elixenide · Accepted Answer · 2013-11-16 06:56:32Z

1

You have this as your foreach loop:

foreach($matches as $match) 
{
    $xhtml = str_replace($match[5],$value,$html);
    echo $xhtml;
}

The echo is inside the loop, so you do one replacement each time, then echo $xhtml each time. What you want is this:

<?php
$html = file_exists('try.html') ? file_get_contents('try.html') : die('unable to open the file');

$data['test1'] = 'WRITE 1';

$data['test2'] = 'WRITE 2';

foreach ($data as $search => $value)
{
    if(preg_match_all('#(<([a-zA-Z]+)[^>]*id=")(.*'.$search.')("[^>]*>)([^<]*?)(</\\2>)#ism', $html, $matches, PREG_SET_ORDER))
    {
        foreach($matches as $match) 
        {
            $html = str_replace($match[5],$value,$html);
        }
    }
}
echo $html;
?>

answered Nov 16, 2013 at 6:56

elixenide

44.9k16 gold badges79 silver badges103 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Darline Over a year ago

quite confussing about the variable $xhtml thats why if I used it will only output a 1 variable value so you used $html to override it. thank you so much. I was just confused on variables.

Collectives™ on Stack Overflow

avoiding a duplicated output in PHP

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related