Displaying array of a Structure/Class Errors C++

Question

So, I have a hero structure that contains name, health, and attack. I'm allowing the user to enter how many heroes they want to create and create an array of that many heroes (I also had problems allowing the user to determine the array size, so the problem could be there). When trying to set the attributes using a loop of the array, I get an error: IntelliSense: no operator "[]" matches these operands. operand types are: Hero [ int ]

My question is, how do I loop through an array of a structures to set their attributes and if so, would displaying the hero's information be similar with a display function?

struct Hero
{
private: 
    string hName;
    int hHealth;
    int hAttack;

public:
    void displayHeroData();
    void setName(string);
    void setHealth(int);
    void setAttack(int);
};

void Hero::displayHeroData()
{
cout << "\n\n\n\nHERO INFO:\n" << endl;
cout << "Name: " << hName << endl;
cout << "Health: " << hHealth << endl;
cout << "Attack: " << hAttack << endl;
};

void Hero::setName(string name)
{
hName = name;
}

void Hero::setHealth(int health)
{
if(health > 0)
    hHealth = health;
else
    hHealth = 100;
}

void Hero::setAttack(int attack)
{
if(attack > 0)
    hAttack = attack;
else
    hAttack = 100;
}

int main()
{
string name;
int health;
int attack;
int num;
Hero *heroList; //declaring array

      //getting size of array
cout << "How many hero's do you want to create? (greater than 0)" <<endl;
cin >> num;
heroList = new Hero[num]; //this is the array of Heroes

      //looping through the array
for(int x = 0; x < num; ++x){

      //creating a new hero, I think???
Hero heroList[x];

      //setting hero's name
cout << "What is hero" << x <<"'s name?" << endl;
cin >> name;
heroList[x].setName(name);

      //display the character after attributes have been set
heroList[x].displayCharacterData();

      }//end of for loop


return 0;
}

hasan · Accepted Answer · 2013-11-17 20:31:53Z

2

Hero heroList[x];

Remove this line for good. no need for it.

answered Nov 17, 2013 at 20:31

hasan

24.2k10 gold badges67 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

CroCo Over a year ago

How did it work? You did reinitialize the array (heroList) with a size which is not constant.

hasan Over a year ago

The answer says that this line should be removed.

CroCo Over a year ago

@hasan, the line must be removed to be more precise otherwise even if his compiler allows that (as he implied), he will get a scope's problem because he reinitialized the array inside the loop.

ordahan · Accepted Answer · 2013-11-17 20:36:04Z

1

The only problem that you will encounter after removing the line proposed (Hero heroList[x]) is that all the hero objects created aren't initialized (when you called new Hero[num] you only allocated the array and created the default implicit constructor for each one).

In order to init all of them, you must either use all your 'setters', or write a non-default constructor and then only allocate an array of Hero* ptrs, and when looping through it init each ptr to a new Hero(.....) with the parameters you wish.

Hope that helps clarify things.

answered Nov 17, 2013 at 20:36

ordahan

1879 bronze badges

Comments

CroCo · Accepted Answer · 2013-11-17 20:42:58Z

1

In the loop just do the following

  //looping through the array
    for(int x = 0; x < num; ++x)
    {
        cout << "What is hero" << x <<"'s name?" << endl;
        cin >> name;
        heroList[x].setName(name);
    }

    for(int x = 0; x < num; ++x)
    {
        heroList[x].displayHeroData();
    }

answered Nov 17, 2013 at 20:42

CroCo

5,87910 gold badges64 silver badges100 bronze badges

Collectives™ on Stack Overflow

Displaying array of a Structure/Class Errors C++

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related