Unable to execute for loop

Question

I'm new to java and just wrote a program for learning purpose. I have two arrays of strings and i want to compare the length of both string arrays.If lengths are equal then compare the values of each first string array with the values of each second array .If value got matched then print that value. Not able to rectify where the problem is ?

     package com.equal.arrat;

    import java.util.ArrayList;
    import java.util.List;

       public class ArrayEqual {
         public static void main(String[] args) {

        String s[] = {"anuj","kr","chaurasia"};
        String s1[] = {"anuj","kr","chaurasia"};

        if (s.length==s1.length)
        {
            System.out.println(s.length);
            for (int i =0 ; i>=s.length;i++)
            {
                for (int j =0 ;j>=s1.length;j++)
                {
                System.out.println("test");
                if (s[i].equals(s1[j]))
                {
                System.out.println("ok" + s[i]);
                }
                else{
                    System.out.println("not ok");
                    }
        }
        }
       }
        else{
            System.out.println("Length Not Equal");
        }
    }
}

JNL · Accepted Answer · 2013-11-19 16:33:36Z

5

Incorrect logic used. What you meant was < instead of >=

for (int i =0 ; i>=s.length;i++)

should be

for (int i =0 ; i<s.length;i++)

Hope this helps. :-)

answered Nov 19, 2013 at 16:33

JNL

4,70120 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Anirban Nag 'tintinmj' Over a year ago

@Littlebird just check if two array contains same elements or not. see stackoverflow.com/questions/14897366/…

JNL Over a year ago

Downvoter... Please leave a comment so that it helps to understand the missing point if any.

Anirban Nag 'tintinmj' · Accepted Answer · 2013-11-19 16:48:46Z

3

At first you are saying i and j is 0 then checking in for loop that if it is greater than s.length or not which is false so it's not executing. Try

for (int i =0 ; i<s.length;i++)
{
    for (int j =0 ;j<s1.length;j++)
    {

edited Nov 19, 2013 at 16:48

answered Nov 19, 2013 at 16:35

Anirban Nag 'tintinmj'

5,8086 gold badges44 silver badges66 bronze badges

1 Comment

Mengjun Over a year ago

code i<=s.length and j<=s1.length is incorrect. You should use j< s1.length and i < s.length instead.

MD Sayem Ahmed · Accepted Answer · 2013-11-19 16:40:54Z

2

You have errors in your for loop condition checks. This line -

for (int i = 0; i >= s.length; i++)

should be changed to this -

for (int i = 0; i < s.length; i++)

Similarly, change this line -

for (int j = 0; j >= s1.length; j++)

to this -

for (int j = 0; j < s1.length; j++)

edited Nov 19, 2013 at 16:40

answered Nov 19, 2013 at 16:34

MD Sayem Ahmed

29.3k27 gold badges115 silver badges183 bronze badges

3 Comments

FatalError Over a year ago

Using <= means that it will also execute with i == s.length which is out of bounds.

MD Sayem Ahmed Over a year ago

@FatalError: Sorry, forgot to remove the = part. Thank you for pointing that out.

MD Sayem Ahmed Over a year ago

@Downvoter: A comment is usually helpful to correct the mistakes.

user2591957 · Accepted Answer · 2013-11-19 16:34:26Z

2

your comparators are off in the for loops. That may be why its not working

if (s.length==s1.length)
{
    System.out.println(s.length);
    for (int i =0 ; i<s.length;i++)
    {
        for (int j =0 ;j<s1.length;j++)
        {
        System.out.println("test");
        if (s[i].equals(s1[j]))
        {
        System.out.println("ok" + s[i]);
        }
        else{
            System.out.println("not ok");
            }
}

answered Nov 19, 2013 at 16:34

user2591957

Comments

Jean-François Corbett · Accepted Answer · 2013-11-19 16:36:55Z

2

for (int i =0 ; i>=s.length;i++)

On first iteration i=0 and s.length=3 and i>=s.length would translate to 0>=3 which is false and hence the loop will not execute. It should be i<=s.length

edited Nov 19, 2013 at 16:36

Jean-François Corbett

38.7k30 gold badges144 silver badges192 bronze badges

answered Nov 19, 2013 at 16:36

user1339772

8036 silver badges19 bronze badges

Comments

score 2 · Accepted Answer · 2013-11-19 17:17:12Z

2

You want to compare the length of both string arrays.If lengths are equal then compare the values of each first string array with the values of each second array .so you cant use this >= for comparing length.

simply try it

 for (int i =0 ; i<s.length;i++)
    {
        for (int j =0 ;j<s1.length;j++)
        {

edited Nov 19, 2013 at 17:17

answered Nov 19, 2013 at 16:38

user2860053

Comments

dev2d · Accepted Answer · 2013-11-19 16:34:11Z

1

change for (int i =0 ; i>=s.length;i++) to

for (int i =0 ; i<s.length;i++)

and same for inner loop

because your first condition itself is not getting satisfied i=0 and you are checking if i>=s.length(means 3 in this case)

so your for loop will not be executed

answered Nov 19, 2013 at 16:34

dev2d

4,2823 gold badges33 silver badges56 bronze badges

Comments

Masudul · Accepted Answer · 2013-11-19 16:50:51Z

1

Your loops are not correct. Try

   for (int i=0; i<s.length; i++)
    {
        for (int j=0; j<s1.length; j++)
        {

edited Nov 19, 2013 at 16:50

answered Nov 19, 2013 at 16:33

Masudul

22k5 gold badges45 silver badges60 bronze badges

Collectives™ on Stack Overflow

Unable to execute for loop

8 Answers 8

2 Comments

1 Comment

3 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

2 Comments

1 Comment

3 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related