C++ 2D array blank output

Question

I am trying to output a 2D array with a border around it but for some odd reason I am not getting any output, just a blank space. I am pretty sure the problem is in the if statement but im not sure whats wrong.

#include <iostream>
#include "windows.h"
using namespace std;

//prototypes
void DisplayMap();
void SetBorder();

//global vars
const int H = 70;
const int W = 40;
char Map[H][W];

int main()
{
    //system("cls");
    DisplayMap();
    SetBorder();

    return 0;
}

void SetBorder(){
for(int i = 0; i < H; i++ ){
    for(int j = 0; j < W; j++){
        if(i == 0 || i == 69 || j == 0 || j == 39 ){ Map[i][j] = 'x';}
            // else Map[i][j] = ' ';
        }
    }
}


void DisplayMap(){
for(int i = 0; i < H; i++ ){
    for(int j = 0; j < W; j++){
            cout << Map[i][j];
        }
            cout << "\n";
    }


}

John Kugelman · Accepted Answer · 2013-11-19 20:26:35Z

3

SetBorder();
DisplayMap();

Swap the function calls. You want to set the border characters first, then display the map.

answered Nov 19, 2013 at 20:26

John Kugelman

364k70 gold badges555 silver badges600 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nemanja Boric · Accepted Answer · 2013-11-19 20:26:56Z

2

You need to fill the Map first and then to display it:

int main()
{
    //system("cls");
    SetBorder();
    DisplayMap();


    return 0;
}

answered Nov 19, 2013 at 20:26

Nemanja Boric

22.2k6 gold badges72 silver badges93 bronze badges

Collectives™ on Stack Overflow

C++ 2D array blank output

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related